Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-313] Undefined names: C --> ctypes #12144

Closed
wants to merge 1 commit into from
Closed

[MXNET-313] Undefined names: C --> ctypes #12144

wants to merge 1 commit into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Aug 13, 2018

Discovered via #8270 (comment)

This could be a copy and paste error where the source file had import ctypes as C whereas this file just has import ctypes

@vandanavk @mkolod @KellenSunderland

Description

(Brief description on what this PR is about)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • C --> ctypes five times

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

Discovered via #8270 (comment)

This could be a copy and paste error where the source file had __import ctypes as C__ whereas this file just has __import ctypes__
@cclauss cclauss requested a review from szha as a code owner August 13, 2018 06:52
@cclauss
Copy link
Contributor Author

cclauss commented Aug 13, 2018

Closed in favor of #12147

@cclauss cclauss closed this Aug 13, 2018
@cclauss cclauss deleted the patch-2 branch August 13, 2018 08:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant