This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Add timeout/retry logic to docker cache download #13573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larroy
reviewed
Dec 7, 2018
ci/docker_cache.py
Outdated
| @@ -131,14 +134,15 @@ def _login_dockerhub(): | |||
| logging.error(p.stderr) | |||
|
|
|||
| # Linear backoff | |||
| time.sleep(1000 * DOCKERHUB_RETRY_SECONDS * (i + 1)) | |||
| time.sleep(DOCKERHUB_RETRY_SECONDS * (i + 1)) | |||
There was a problem hiding this comment.
can we use @Retry decorator, it's in util under CI I think. just so we don't reimplement retry logic everytime. Or maybe you can abstract this in another retry_with_timeout deco.
There was a problem hiding this comment.
Done, thanks for the suggestion :)
There was a problem hiding this comment.
Wanted to keep this PR specific to this method, but I guess it makes more sense to add it also, done
nswamy
added
CI
pr-awaiting-response
larroy
approved these changes
Dec 10, 2018
jlcontreras
force-pushed
the
docker-cache-timeout
branch
from
02b60f1
to
b25984a
Compare
lebeg
approved these changes
Dec 13, 2018
|
@mxnet-label-bot update[CI, pr-awaiting-merge] |
marcoabreu
added
pr-awaiting-merge
|
@marcoabreu @KellenSunderland Can someone merge this PR? |
KellenSunderland
approved these changes
Dec 21, 2018
rondogency
pushed a commit
to rondogency/incubator-mxnet
that referenced
this pull request
Jan 9, 2019
* Added timeout/retry (linear backoff) to docker cache download * Units changed, as time.sleep takes seconds as argument * Improved error handling * Using retry decorator * Added retry decorator to _login_dockerhub method * Fixed wrong import
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
* Added timeout/retry (linear backoff) to docker cache download * Units changed, as time.sleep takes seconds as argument * Improved error handling * Using retry decorator * Added retry decorator to _login_dockerhub method * Fixed wrong import
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dockerhub sometimes has unstable behavior, causing downloads to take much longer than they should. Average download time is below 2min, but in some rare cases it can take more than 1h (see http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/incubator-mxnet/detail/master/2033/pipeline/ for example)
This PR wraps the cache download call with timeout/retry logic as a fix