Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-880] ONNX export: Random uniform, Random normal, MaxRoiPool #13676

Merged
merged 3 commits into from
Jan 10, 2019
Merged

[MXNET-880] ONNX export: Random uniform, Random normal, MaxRoiPool #13676

merged 3 commits into from
Jan 10, 2019

Conversation

vandanavk
Copy link
Contributor

@vandanavk vandanavk commented Dec 18, 2018 •
edited
Loading

Description

ONNX export plus test for Random Uniform, Random Normal, and MaxRoiPool.

Fixes #12925

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

-export the operators, write custom tests as ONNX doesn't have tests for these

Comments

@vandanavk vandanavk requested a review from szha as a code owner December 18, 2018 19:48
@vandanavk
Copy link
Contributor Author

@mxnet-label-bot add [ONNX, pr-work-in-progress]

@marcoabreu marcoabreu added ONNX pr-work-in-progress PR is still work in progress labels Dec 18, 2018
@vandanavk vandanavk changed the title [WIP] ONNX export: Random uniform, Random normal [WIP] ONNX export: Random uniform, Random normal, MaxRoiPool Dec 18, 2018
@vandanavk vandanavk changed the title [WIP] ONNX export: Random uniform, Random normal, MaxRoiPool ONNX export: Random uniform, Random normal, MaxRoiPool Dec 19, 2018
@vandanavk
Copy link
Contributor Author

@mxnet-label-bot update [ONNX, pr-awaiting-review]

@marcoabreu marcoabreu added pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress labels Dec 19, 2018
@vandanavk vandanavk changed the title ONNX export: Random uniform, Random normal, MaxRoiPool [MXNET-880] ONNX export: Random uniform, Random normal, MaxRoiPool Dec 19, 2018
@vandanavk vandanavk force-pushed the onnx_unit_test_part_2 branch 2 times, most recently from 8d55166 to 2769ed1 Compare December 27, 2018 21:22
@vandanavk
Copy link
Contributor Author

vandanavk commented Jan 9, 2019 •
edited
Loading

@anirudhacharya @zhreshold for review

@Roshrini Roshrini merged commit 70316d6 into apache:master Jan 10, 2019
zhaoyao73 added a commit to zhaoyao73/incubator-mxnet that referenced this pull request Jan 11, 2019
@zhaoyao73
Merge remote-tracking branch 'upstream/master'
7c21b53 
* upstream/master: (109 commits)
  Code modification for  testcases of various network models in directory example (apache#12498)
  [CI] Prevent timeouts when rebuilding containers with docker. (apache#13818)
  fix Makefile for rpkg (apache#13590)
  change to compile time (apache#13835)
  Disabled flaky test (apache#13758)
  Improve license_header tool by only traversing files under revision c… (apache#13803)
  Removes unneeded nvidia driver ppa installation (apache#13814)
  Add Local test stage and option to jump directly to menu item from commandline (apache#13809)
  Remove MXNET_STORAGE_FALLBACK_LOG_VERBOSE from test_autograd.py (apache#13830)
  Fix scala doc build break for v1.3.1 (apache#13820)
  [MXNET-1263] Unit Tests for Java Predictor and Object Detector APIs (apache#13794)
  [MXNET-1260] Float64 DType computation support in Scala/Java (apache#13678)
  onnx export ops (apache#13821)
  [MXNET-880] ONNX export: Random uniform, Random normal, MaxRoiPool (apache#13676)
  fix minor indentation (apache#13827)
  Fixing a symlink issue with R install (apache#13708)
  remove useless code (apache#13777)
  ONNX ops: norm exported and lpnormalization imported (apache#13806)
  Add new Maven build for Scala package (apache#13819)
  Dockerfiles for Publish Testing (apache#13707)
  ...
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
@vandanavk
[MXNET-880] ONNX export: Random uniform, Random normal, MaxRoiPool (a…
b978957 
…pache#13676)

* ONNX export: Random uniform, Random normal

* ONNX export: MaxRoiPool

* tests for maxroipool, randomnormal, randomuniform
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Roshrini Roshrini Roshrini approved these changes

@zhreshold zhreshold zhreshold approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
ONNX pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Support ONNX export of _rdiv_scalar, _sample_multinomial, _sample_uniform operators
4 participants
@vandanavk @zhreshold @Roshrini @marcoabreu