-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Fix the quantization script to support Python2 #13700
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have similar problem with imagenet_inference.py
and imagenet_gen_qsym.py
?
@TaoLv Thanks for the comments, I checked the two scripts you mentioned, and indeed the imagenet_inference.py has similiar issue and modify it accordingly, imagenet_gen_qsym.py works well with Python2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix. LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the enhance.
@TaoLv could you help merge this one? |
Thank you for the contribution. Now merging. |
* fix the quantization script to support python2 * Fix comments, fix similiar issue in imagenet_inference.py
* fix the quantization script to support python2 * Fix comments, fix similiar issue in imagenet_inference.py
Description
The existing quantization script under https://github.com/apache/incubator-mxnet/blob/master/example/quantization/imagenet_gen_qsym_mkldnn.py can't run properly on using Python 2.7. This PR provide a fix to make it compatible with Python2.x and 3.x.
@xinyu-intel @TaoLv
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
https://github.com/apache/incubator-mxnet/blob/master/example/quantization/imagenet_gen_qsym_mkldnn.py