Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-1177]Adding Scala Demo to be run as a part of Nightly CI #13823

Merged
merged 6 commits into from
Jan 14, 2019

Conversation

piyushghai
Copy link
Contributor

Description

As title.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@lanking520 @zachgk @andrewfayres @marcoabreu

@anirudhacharya
Copy link
Member

@mxnet-label-bot add [pr-awaiting-review, Scala]

@marcoabreu marcoabreu added pr-awaiting-review PR is waiting for code review Scala labels Jan 10, 2019
ci/docker/runtime_functions.sh Show resolved Hide resolved
scala-package/mxnet-demo/java-demo/Makefile Outdated Show resolved Hide resolved
Copy link
Member

@lanking520 lanking520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Users build will be broken on Java since there is no 1.4.0 package ready yet.

@lanking520 lanking520 merged commit 22e2ef8 into apache:master Jan 14, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
…he#13823)

* Adding Scala Demo to be run as a part of Nightly CI

* Addressed PR feedback : making a profile to fetch nightly jars only on CI

* Changed name from scalacidemo to scala_ci_demo

* Synchronized the scala-demo and java-demo for nightly CI runs

* Pruned the maven command to simply maven install

* changed running from ./.sh to bash .sh to be consistent
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review Scala
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants