Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Add copyrights for third party licenses to license file #13851

Merged
merged 1 commit into from
Jan 11, 2019

Conversation

zachgk
Copy link
Contributor

@zachgk zachgk commented Jan 11, 2019

Description

Based on feedback from Justin Mclean as part of the 1.4 release, we should include copyright notices in our license (https://mail-archives.apache.org/mod_mbox/incubator-general/201901.mbox/browser). This PR adds them.

@aaronmarkham @frankfliu @lanking520 @andrewfayres @srochel

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Copy link
Member

@gigasquid gigasquid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from Clojure side

Copy link
Member

@lanking520 lanking520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on Scala end.

@lanking520 lanking520 merged commit c4761d0 into apache:master Jan 11, 2019
zachgk added a commit to zachgk/incubator-mxnet that referenced this pull request Jan 11, 2019
lanking520 pushed a commit that referenced this pull request Jan 16, 2019
* Update LICENSE File with subcomponents (#13808)

* Update LICENSE File with subcomponents

* Fix JavaScript licenses

* Add copyrights for third party licenses to license file (#13851)

* Remove R-package from LICENSE

* Update googletest due to licensing
lanking520 pushed a commit to lanking520/incubator-mxnet that referenced this pull request Feb 18, 2019
* Update LICENSE File with subcomponents (apache#13808)

* Update LICENSE File with subcomponents

* Fix JavaScript licenses

* Add copyrights for third party licenses to license file (apache#13851)

* Remove R-package from LICENSE

* Update googletest due to licensing
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
@roywei roywei mentioned this pull request Jan 17, 2020
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants