Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Hot Fix]Temporary Disable MKL-DNN for building R-Package #13867

Closed
wants to merge 2 commits into from

Conversation

xinyu-intel
Copy link
Contributor

@xinyu-intel xinyu-intel commented Jan 13, 2019

Description

This is a hot-fix for #13859. Temporary disable MKL-DNN for building R-Package since it needs plan and time to evaluate the functionality, stability and performance of R when building MXNet with MKL-DNN.
@TaoLv @pengzhao-intel

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@xinyu-intel xinyu-intel changed the title Disable MKL-DNN for R-Package build [Hot Fix]Temporary Disable MKL-DNN for building R-Package Jan 13, 2019
@pengzhao-intel
Copy link
Contributor

One more, we need to add the CI build for R + MKLDNN later.

@huangzhiyuan
Copy link
Contributor

I have meet the same CI fail issue, The fix pr #13841 is WIP.

@anirudhacharya
Copy link
Member

@mxnet-label-bot add [pr-awaiting-review]

@marcoabreu marcoabreu added the pr-awaiting-review PR is waiting for code review label Jan 14, 2019
@TaoLv
Copy link
Member

TaoLv commented Jan 16, 2019

@xinyu-intel can you rebase code retrigger CI?

@sandeep-krishnamurthy
Copy link
Contributor

@TaoLv - Can you take a look back at this PR? Builds are green now.

@TaoLv
Copy link
Member

TaoLv commented Jan 29, 2019

@sandeep-krishnamurthy I notice there is another PR (#13952) working on the fix. I would hope that PR can be merged soon and then we don't need a hot fix for the issue. @xinyu-intel Please confirm, thank you.

@xinyu-intel
Copy link
Contributor Author

@sandeep-krishnamurthy @TaoLv Yes, #13952 can fix this. I'll close it once #13952 merged.

@xinyu-intel
Copy link
Contributor Author

#13952 merged. Close this PR now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review R
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants