Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

MXNET-1295 Adding integer index support to Sequence* family of operators. #13880

Merged
merged 6 commits into from
Jan 27, 2019
Merged

MXNET-1295 Adding integer index support to Sequence* family of operators. #13880

merged 6 commits into from
Jan 27, 2019

Commits on Jan 15, 2019

  1. Adding integer index support to Sequence* family of operators. 

    Adding ability to use int32 arrays, or any castable-to-int type, as
the sequence_length array to SequenceMask, SequenceLast, and
SequenceReverse. Previously these operaters all requred sequence_length
to be the same data type as the input array.

See MxNet Jira ticket here:
  https://issues.apache.org/jira/browse/MXNET-1295

See also GitHub issues here:
   apache#12649
   dmlc/gluon-nlp#346
    @stephenrawls
    stephenrawls committed Jan 15, 2019
    Configuration menu
    Copy the full SHA
    63c5b1e View commit details
    Browse the repository at this point in the history

  2. Adding explicit braces to an if statement to fix g++ warning

    @stephenrawls
    stephenrawls committed Jan 15, 2019
    Configuration menu
    Copy the full SHA
    18b0729 View commit details
    Browse the repository at this point in the history

  3. fixing sequence_mask.cu by adding IType to template

    @stephenrawls
    stephenrawls committed Jan 15, 2019
    Configuration menu
    Copy the full SHA
    e5fc78f View commit details
    Browse the repository at this point in the history

  4. Fixing whitespace errors reported by linter

    @stephenrawls
    stephenrawls committed Jan 15, 2019
    Configuration menu
    Copy the full SHA
    c1754b8 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2019

  1. Adding unit tests

    @stephenrawls
    stephenrawls committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    449cc29 View commit details
    Browse the repository at this point in the history

  2. Fixing length of lines to pass linter

    @stephenrawls
    stephenrawls committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    55ed0d6 View commit details
    Browse the repository at this point in the history