This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Use In-place operator to prevent memory spikes in optimizer updates #13960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some statistics from Adadelta Old
Adadelta New
Adamax Old
Adamax New
|
@mxnet-label-bot add [pr-awaiting-review] |
For 5 batches of training with a deep embeddings example the decrease in memory consumption is ~0.27 factor for Nesterov Adam optimizer. Old Nadam - New Nadam( with in-place operators) - |
eric-haibin-lin
approved these changes
Jan 25, 2019
vandanavk
approved these changes
Feb 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mxnet-label-bot update [pr-awaiting-merge] |
marcoabreu
added
pr-awaiting-merge
Review and CI is complete. Ready to Merge
and removed
pr-awaiting-review
PR is waiting for code review
labels
Feb 5, 2019
@sandeep-krishnamurthy Could you please review/merge this PR? |
Thanks for merging and thanks to @szha for the tip here - #13683 (comment) |
stephenrawls
pushed a commit
to stephenrawls/incubator-mxnet
that referenced
this pull request
Feb 16, 2019
jessr92
pushed a commit
to jessr92/incubator-mxnet
that referenced
this pull request
Feb 19, 2019
drivanov
pushed a commit
to drivanov/incubator-mxnet
that referenced
this pull request
Mar 4, 2019
vdantu
pushed a commit
to vdantu/incubator-mxnet
that referenced
this pull request
Mar 31, 2019
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The update rules in Nadam, Adadelta, Adamax and SGLD optimizers have been changed to using in-place operators to prevent memory spikes during execution.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.