Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix inconsistent handling for FResourceRequestEx for imperative and symbolic executor #14007

Merged
merged 2 commits into from
Jan 31, 2019
Merged

Fix inconsistent handling for FResourceRequestEx for imperative and symbolic executor #14007

merged 2 commits into from
Jan 31, 2019

Conversation

eric-haibin-lin
Copy link
Member

@eric-haibin-lin eric-haibin-lin commented Jan 28, 2019 •
edited
Loading

Description

During imperative execution, if an op registers both FResourceRequestEx and FResourceRequest, FResourceRequestEx is used.
However, during symbolic execution, such behavior causes a fatal message.

This PR removes the fatal message in symbolic execution so that it is consistent with the imperative execution.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@eric-haibin-lin eric-haibin-lin changed the title [DOC] Update FResourceRequestEx, FResourceRequest documentation [WIP] [DOC] Update FResourceRequestEx, FResourceRequest documentation Jan 28, 2019
@sandeep-krishnamurthy sandeep-krishnamurthy added Doc pr-work-in-progress PR is still work in progress labels Jan 28, 2019
@eric-haibin-lin eric-haibin-lin changed the title [WIP] [DOC] Update FResourceRequestEx, FResourceRequest documentation Fix inconsistent handling for FResourceRequestEx for imperative and symbolic executor Jan 31, 2019
@eric-haibin-lin
Copy link
Member Author

@szha pls review

@eric-haibin-lin eric-haibin-lin merged commit 8102606 into apache:master Jan 31, 2019
stephenrawls pushed a commit to stephenrawls/incubator-mxnet that referenced this pull request Feb 16, 2019
@eric-haibin-lin @stephenrawls
Fix inconsistent handling for FResourceRequestEx for imperative and s…
87b6711 
…ymbolic executor (apache#14007)

* Update op_attr_types.h

* Update attach_op_resource_pass.cc
vdantu pushed a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019
@eric-haibin-lin @vdantu
Fix inconsistent handling for FResourceRequestEx for imperative and s…
c40b1dc 
…ymbolic executor (apache#14007)

* Update op_attr_types.h

* Update attach_op_resource_pass.cc
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
@eric-haibin-lin
Fix inconsistent handling for FResourceRequestEx for imperative and s…
3864c40 
…ymbolic executor (apache#14007)

* Update op_attr_types.h

* Update attach_op_resource_pass.cc
@eric-haibin-lin eric-haibin-lin deleted the attr-doc branch September 2, 2019 23:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@szha szha szha approved these changes

@anirudh2290 anirudh2290 Awaiting requested review from anirudh2290

Assignees
No one assigned
Labels
Doc pr-work-in-progress PR is still work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eric-haibin-lin @szha @sandeep-krishnamurthy