Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-1318] Now passing DType of Label downstream to Label's DataDesc object #14038

Merged
merged 1 commit into from
Feb 1, 2019

Conversation

piyushghai
Copy link
Contributor

Description

Currently, the label's data descriptor in NDArrayIter.scala does not allow one to specify the dType for the labels passed. It is hardcoded at MX_REAL_TYPE. This PR addresses that.
Fixes #14037

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@lanking520 @andrewfayres @zachgk

Copy link
Member

@lanking520 lanking520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also check the other iterators to make sure they could also work?

@piyushghai
Copy link
Contributor Author

Could you please also check the other iterators to make sure they could also work?

Already did :) They all work fine.

Copy link
Member

@lanking520 lanking520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lanking520 lanking520 merged commit f95e794 into apache:master Feb 1, 2019
@piyushghai piyushghai deleted the label_float64 branch February 1, 2019 18:03
stu1130 added a commit to stu1130/incubator-mxnet that referenced this pull request Feb 1, 2019
stephenrawls pushed a commit to stephenrawls/incubator-mxnet that referenced this pull request Feb 16, 2019
vdantu pushed a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add DType support for NDArrayIter for the label DataDescriptor
3 participants