-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
@@ -1,3 +1,22 @@ | |||
<!--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was missed from #13647 even though I made the comment on the PR about the same (see #13647 (comment))
@szha Thanks for your contribution! @mxnet-label-bot add [pr-work-in-progress, website, build] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment style seems to be incompatible with the docs tool chain.
I tried this style and it works:
[//]: # (Licensed to the Apache Software Foundation under one)
Note I had to get rid of the (ASF)
as I couldn't figure out how to escape the parenthesis. 🤷♂️
If the RAT script looks for the specific string, then, well, I guess we still have a problem, but now in a different spot.
You could just add another option for the rat check to check.
My suggestion comes from this discussion on markdown comments: https://stackoverflow.com/questions/4823468/comments-in-markdown |
Try this instead:
I have it working here: http://34.201.8.176/versions/fix_web/api/clojure/index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It passed the test and seemed to be rendering fine. LGTM
* fix rendering of markdown doc * fix missing license from lipnet example
* fix rendering of markdown doc * fix missing license from lipnet example
* make rat-excludes compliant with apache release policy (#14142) * remove md from whitelist * remove rst from whitelist * remove docker folder from whitelist * remove docs from whitelist * fix website build (#14148) * fix rendering of markdown doc * fix missing license from lipnet example * fix diff
* fix rendering of markdown doc * fix missing license from lipnet example
* make rat-excludes compliant with apache release policy (apache#14142) * remove md from whitelist * remove rst from whitelist * remove docker folder from whitelist * remove docs from whitelist * fix website build (apache#14148) * fix rendering of markdown doc * fix missing license from lipnet example * fix diff
* fix rendering of markdown doc * fix missing license from lipnet example
* fix rendering of markdown doc * fix missing license from lipnet example
* fix rendering of markdown doc * fix missing license from lipnet example
* fix rendering of markdown doc * fix missing license from lipnet example
Description
fix website build caused by #14142
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes