Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-1305] Scala interpreter instructions #14169

Merged
merged 1 commit into from
Feb 19, 2019

Conversation

zachgk
Copy link
Contributor

@zachgk zachgk commented Feb 14, 2019

Description

Add instructions to the scala_setup page for using the interpreter and link to in the only example featuring the interpreter. It also adds a note that we only support scala 2.11. This should address the problem seen in #13468.

@lanking520 @piyushghai @andrewfayres @aaronmarkham

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@zachgk zachgk requested a review from szha as a code owner February 14, 2019 19:57
@ankkhedia
Copy link
Contributor

ankkhedia commented Feb 15, 2019

@zachgk Thanks for the contribution!
@mxnet-label-bot add [pr-awaiting-review, Scala]

@lanking520 @piyushghai @andrewfayres
Could you please help review this PR?

@marcoabreu marcoabreu added pr-awaiting-review PR is waiting for code review Scala labels Feb 15, 2019
@lanking520 lanking520 merged commit c45e534 into apache:master Feb 19, 2019
jessr92 pushed a commit to jessr92/incubator-mxnet that referenced this pull request Feb 28, 2019
jessr92 pushed a commit to jessr92/incubator-mxnet that referenced this pull request Feb 28, 2019
jessr92 pushed a commit to jessr92/incubator-mxnet that referenced this pull request Feb 28, 2019
drivanov pushed a commit to drivanov/incubator-mxnet that referenced this pull request Mar 4, 2019
vdantu pushed a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019
@zachgk zachgk deleted the interpreter branch April 12, 2019 22:23
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review Scala
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants