This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[MXNET-1327] Allow RNN Layers to be initialized to fp16 #14219
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think you've linked with the wrong JIRA ticket for this PR... the title of MXNET-939 JIRA ticket is actually "Variance Operator". |
ThomasDelteil
changed the title
[MXNET-939] Allow RNN Layers to be initialized to fp16
[MXNET-1327] Allow RNN Layers to be initialized to fp16
Feb 21, 2019
roywei
approved these changes
Feb 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, LGTM!
@mxnet-label-bot add[Gluon, RNN, FP16] |
Could you fix the test? Thanks! |
eric-haibin-lin
approved these changes
Mar 12, 2019
This was referenced Mar 26, 2019
vdantu
pushed a commit
to vdantu/incubator-mxnet
that referenced
this pull request
Mar 31, 2019
* update rnn for fp16 * fix typo in test * fix tests * fix tests * fix gpu tests * Update test_gluon_rnn.py * Update test_gluon_rnn.py * trigger * try removing checks for unix
nswamy
pushed a commit
that referenced
this pull request
Apr 5, 2019
* update rnn for fp16 * fix typo in test * fix tests * fix tests * fix gpu tests * Update test_gluon_rnn.py * Update test_gluon_rnn.py * trigger * try removing checks for unix
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
* update rnn for fp16 * fix typo in test * fix tests * fix tests * fix gpu tests * Update test_gluon_rnn.py * Update test_gluon_rnn.py * trigger * try removing checks for unix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently if you hybridize a RNN layers, it doesn't work with fp16 except if you explicitly give fp16 states as initial states. This makes it cumbersome to use.
This PR updates the RNN layers to have a dtype that is used for the default states and is updated upon casting.
Currently
gives
After the fix
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
dtype
param to RNN layers