Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-1331] Removal of non-MXNET classes from JAR #14303

Merged
merged 1 commit into from
Mar 6, 2019

Conversation

jessr92
Copy link
Contributor

@jessr92 jessr92 commented Mar 2, 2019

Consumers of MXNet are exposed to the library versions MXNet uses internally. This change excludes those JARs from the JARs created with make scalapkg.

Description

This PR removes 3rd party libraries from the assembled JAR and adds both packages as dependencies in deploy.xml

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • slf4j-api and args4j remove from assembled JAR
  • slf4j-api and args4j added as dependencies to deploy.xml

Comments

My Maven knowledge is sparse so I may have missed something.

For testing:

  • The JAR no longer contains non-org.apache.mxnetclasses
  • make scalapkg && make scalaunittests && make scalaintegrationtests passed on my Ubuntu 18.04 machine (JDK 8).

Related to #14000

@jessr92
Copy link
Contributor Author

jessr92 commented Mar 2, 2019

@mxnet-label-bot update [Scala, Maven, pr-awaiting-review]

Copy link
Contributor

@ChaiBapchya ChaiBapchya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. CI bug - Can you please retrigger by pushing empty commit

git commit --allow-empty -m "Trigger notification"

@jessr92
Copy link
Contributor Author

jessr92 commented Mar 4, 2019

Thanks. All looks well now.

@szha szha merged commit 19d737f into apache:master Mar 6, 2019
vdantu pushed a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Maven pr-awaiting-review PR is waiting for code review Scala
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants