Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Add MKLDNN headers to pip package #14339

Merged
merged 2 commits into from
Mar 7, 2019
Merged

Add MKLDNN headers to pip package #14339

merged 2 commits into from
Mar 7, 2019

Conversation

yuxihu
Copy link
Member

@yuxihu yuxihu commented Mar 6, 2019

Following 14300, to support running Horovod with MKLDNN enabled MXNet pip packages, we also need to add MKLDNN headers to MXNet pip packages.

@yuxihu yuxihu requested a review from szha as a code owner March 6, 2019 00:55
@yuxihu
Copy link
Member Author

yuxihu commented Mar 6, 2019

@lanking520 @apeforest @szha please help review.
@mxnet-label-bot update [pr-awaiting-review]

@marcoabreu marcoabreu added the pr-awaiting-review PR is waiting for code review label Mar 6, 2019
tools/pip/setup.py Outdated Show resolved Hide resolved
Copy link
Contributor

@cchung100m cchung100m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@szha szha merged commit efb8823 into apache:master Mar 7, 2019
@yuxihu yuxihu deleted the mkldnn_pip branch March 7, 2019 07:06
vdantu pushed a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019
* add MKLDNN headers to pip package

* only add headers for mkl packages
nswamy pushed a commit that referenced this pull request Apr 5, 2019
* add MKLDNN headers to pip package

* only add headers for mkl packages
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
* add MKLDNN headers to pip package

* only add headers for mkl packages
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants