Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

support leading dimension of -1 in ravel/unravel #14356

Merged
merged 1 commit into from
Mar 11, 2019

Conversation

asmushetzel
Copy link
Contributor

@asmushetzel asmushetzel commented Mar 7, 2019

Description

Fixes #13862
Using "-1" for the leading shape dimension was not officially documented but happened to work in versions 1.3.1 or lower as mshadow::index_t was unsigned so -1 was eventually interpreted as maxint. In subsequent versions of mxnet, mshadow::index_t has been changed to a signed type such that using -1 as leading shape dimension did not work anymore.
This fix documents that -1 is an allowed value for the leading dimension and re-enable behaviour of version 1.3.1. Note that it is natural to assume that this use case is supported as the value of the leading dimension of the shape is not needed for ravel/unravel computations anyway. Also it seems from above issue, that there are valid customer use cases that need support for this.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • [ X] Changes are complete (i.e. I finished coding on this PR)
  • [ X] All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • [ X] Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • [X ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@asmushetzel
Copy link
Contributor Author

Done from my side.

@vandanavk
Copy link
Contributor

@mxnet-label-bot add [Operator, pr-awaiting-review]

@asmushetzel Please add "Fixes #13862" in the PR description to automatically close the issue when this PR is merged

@marcoabreu marcoabreu added Operator pr-awaiting-review PR is waiting for code review labels Mar 7, 2019
@asmushetzel
Copy link
Contributor Author

Added the "Fixes #13862" in the PR description

@vandanavk
Copy link
Contributor

@apeforest @samskalicky @anirudh2290 for review

Copy link
Contributor

@samskalicky samskalicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @vandanavk!

@wkcn wkcn added pr-awaiting-merge Review and CI is complete. Ready to Merge and removed pr-awaiting-review PR is waiting for code review labels Mar 11, 2019
@wkcn wkcn merged commit 35098b8 into apache:master Mar 11, 2019
@wkcn
Copy link
Member

wkcn commented Mar 11, 2019

The PR has been merged.
Thanks for your contribution!

@asmushetzel asmushetzel deleted the ravel_fix branch March 11, 2019 08:44
vdantu pushed a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Operator pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1.4.0] unravel_index no longer works with magic '-1' in shape parameter as in 1.3.1
5 participants