This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haojin2
force-pushed
the
speed_sequence_mask
branch
from
March 16, 2019 02:15
99e82d3
to
9baa31d
Compare
@eric-haibin-lin @szha for review. |
haojin2
force-pushed
the
speed_sequence_mask
branch
2 times, most recently
from
March 16, 2019 06:40
f312304
to
efb4dc1
Compare
@mxnet-label-bot add [CUDA, Operator, Performance, pr-awaiting-review] |
marcoabreu
added
CUDA
Operator
Performance
pr-awaiting-review
PR is waiting for code review
labels
Mar 17, 2019
@eric-haibin-lin @szha ping for review. |
eric-haibin-lin
suggested changes
Mar 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement! Two comments:
haojin2
force-pushed
the
speed_sequence_mask
branch
from
March 25, 2019 20:56
efb4dc1
to
0d5c11a
Compare
@eric-haibin-lin please check |
haojin2
force-pushed
the
speed_sequence_mask
branch
from
March 27, 2019 00:09
0d5c11a
to
8339f09
Compare
eric-haibin-lin
approved these changes
Mar 27, 2019
vdantu
pushed a commit
to vdantu/incubator-mxnet
that referenced
this pull request
Mar 31, 2019
ZhennanQin
pushed a commit
to ZhennanQin/incubator-mxnet
that referenced
this pull request
Apr 3, 2019
nswamy
pushed a commit
that referenced
this pull request
Apr 5, 2019
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As title. Address #14124.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments
benchmark results on sample workload from #14124:
forward only: 48.589637756347656 ms -> 0.5544562339782715 ms 87.63x speedup
forward+backward: 97.38378977775574 ms -> 1.224109172821045 ms 79.55x speedup