Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix flaky test poisson generator & test_negative_binomial_generator #14571

Merged
merged 3 commits into from
Apr 3, 2019

Conversation

stu1130
Copy link
Contributor

@stu1130 stu1130 commented Mar 30, 2019

Description

Related to #14540
Fixes #13584 Fixes #13506
Adjust the default success_rate back to 0.2.
Originally it was 0.25 after #13498 it changed to 0.15.

passed all the previous failed seed.
ran both of the test case 10k times

MXNET_TEST_COUNT=10000 nosetests -v test_operator_gpu.test_poisson_generator
[INFO] Setting module np/mx/python random seeds, use MXNET_MODULE_SEED=1635133297 to reproduce.
test_operator_gpu.test_poisson_generator ... ok

----------------------------------------------------------------------
Ran 1 test in 20881.518s

OK

MXNET_TEST_COUNT=10000 nosetests -v test_operator_gpu.test_negative_binomial_generator
[INFO] Setting module np/mx/python random seeds, use MXNET_MODULE_SEED=636644805 to reproduce.
test_operator_gpu.test_negative_binomial_generator ... ok

----------------------------------------------------------------------
Ran 1 test in 26051.124s

OK

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

Comments

@stu1130 stu1130 requested a review from szha as a code owner March 30, 2019 00:13
@stu1130 stu1130 force-pushed the fix_test_poisson_generator branch 2 times, most recently from 97807b9 to 62499a8 Compare April 1, 2019 22:53
@piyushghai
Copy link
Contributor

@stu1130 Thanks for fixing the flaky tests.

@mxnet-label-bot Add [CI, Flaky, pr-awaiting-review]

@marcoabreu marcoabreu added CI Flaky pr-awaiting-review PR is waiting for code review labels Apr 2, 2019
Copy link
Contributor

@piyushghai piyushghai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@piyushghai
Copy link
Contributor

@stu1130 Can you look into the CI failures though ?

@stu1130 stu1130 force-pushed the fix_test_poisson_generator branch from 62499a8 to 9822b17 Compare April 2, 2019 18:01
Copy link
Contributor

@larroy larroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@szha
Copy link
Member

szha commented Apr 2, 2019

@stu1130 could you rebase to the latest master?

@stu1130
Copy link
Contributor Author

stu1130 commented Apr 2, 2019

@szha I have rebased to the latest master

commit 9822b17f36be6c6409b01371ca5aaafe6b204f2f (HEAD -> fix_test_poisson_generator, origin/fix_test_poisson_generator)
Author: stu1130 <*****@gmail.com>
Date:   Wed Mar 27 14:08:34 2019 -0700

    fix the flaky test

commit 8a64f606c2d9407db5ca0fe8e4dbfc61e45aee2b
Author: stu1130 <*****@gmail.com>
Date:   Wed Mar 27 10:12:34 2019 -0700

    set success_rate to 0.2

commit e2f5b47346e148c2376da7e6628750747f2d6a94 (upstream/master)
Author: JackieWu <wkcn@live.cn>
Date:   Wed Apr 3 01:53:02 2019 +0800

    Support SyncBatchNorm5D (#14542)

    * support SyncBatchNorm5D

    * fix
...

@stu1130 stu1130 force-pushed the fix_test_poisson_generator branch from 9822b17 to 379aed2 Compare April 2, 2019 21:36
@szha szha merged commit a6fd0e9 into apache:master Apr 3, 2019
ZhennanQin pushed a commit to ZhennanQin/incubator-mxnet that referenced this pull request Apr 3, 2019
…pache#14571)

* set success_rate to 0.2

* fix the flaky test

* reenable the test
nswamy pushed a commit that referenced this pull request Apr 5, 2019
…14571)

* set success_rate to 0.2

* fix the flaky test

* reenable the test
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
…pache#14571)

* set success_rate to 0.2

* fix the flaky test

* reenable the test
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI Flaky pr-awaiting-review PR is waiting for code review
Projects
None yet
5 participants