This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Fix flaky test poisson generator & test_negative_binomial_generator #14571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stu1130
force-pushed
the
fix_test_poisson_generator
branch
2 times, most recently
from
April 1, 2019 22:53
97807b9
to
62499a8
Compare
@stu1130 Thanks for fixing the flaky tests. @mxnet-label-bot Add [CI, Flaky, pr-awaiting-review] |
piyushghai
approved these changes
Apr 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@stu1130 Can you look into the CI failures though ? |
stu1130
force-pushed
the
fix_test_poisson_generator
branch
from
April 2, 2019 18:01
62499a8
to
9822b17
Compare
larroy
approved these changes
Apr 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@stu1130 could you rebase to the latest master? |
@szha I have rebased to the latest master
|
stu1130
force-pushed
the
fix_test_poisson_generator
branch
from
April 2, 2019 21:36
9822b17
to
379aed2
Compare
ZhennanQin
pushed a commit
to ZhennanQin/incubator-mxnet
that referenced
this pull request
Apr 3, 2019
…pache#14571) * set success_rate to 0.2 * fix the flaky test * reenable the test
nswamy
pushed a commit
that referenced
this pull request
Apr 5, 2019
…14571) * set success_rate to 0.2 * fix the flaky test * reenable the test
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
…pache#14571) * set success_rate to 0.2 * fix the flaky test * reenable the test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #14540
Fixes #13584 Fixes #13506
Adjust the default success_rate back to 0.2.
Originally it was 0.25 after #13498 it changed to 0.15.
passed all the previous failed seed.
ran both of the test case 10k times
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments