Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-1379] update reshape operator #14600

Merged
merged 3 commits into from
Apr 3, 2019
Merged

Conversation

lanking520
Copy link
Member

@lanking520 lanking520 commented Apr 2, 2019

Description

This is a fix to the issue #14590
using the same operator with Python
@szha @stu1130 @zachgk @andrewfayres

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@lanking520 lanking520 added Scala Java Label to identify Java API component labels Apr 2, 2019
@lanking520 lanking520 self-assigned this Apr 2, 2019
Copy link
Contributor

@piyushghai piyushghai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contributions @lanking520

Copy link
Contributor

@stu1130 stu1130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@szha szha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if you foresee no issue in dropping the mxNDArrayReshape interfaces

@lanking520 lanking520 merged commit b482a44 into apache:master Apr 3, 2019
nswamy pushed a commit that referenced this pull request Apr 5, 2019
* update reshape operator

* Satisfy the Lint God =v=

* update the jni header signature
@lanking520 lanking520 deleted the fix-reshape branch April 8, 2019 18:28
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
* update reshape operator

* Satisfy the Lint God =v=

* update the jni header signature
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Java Label to identify Java API component Scala
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants