This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[MXNET-1287] Miscellaneous Scala warning fixes #14658
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mxnet-label-bot add [Scala, Maven, pr-awaiting-review] |
lanking520
reviewed
Apr 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
switch println
to logger.debug
?
Honestly, I don't think there is any merit in keeping them. If you actually needed to see that information, you would probably be better off adding the specific debug statements you need or just using a debugger. It is most likely just left in by accident from development and should not have been checked into git at all |
lanking520
approved these changes
Apr 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
12 tasks
larroy
pushed a commit
to larroy/mxnet
that referenced
this pull request
Apr 15, 2019
* Remove printing during tests * Fix macro annotation warnings * Remove failing links from spark * Return printed as debug logs
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
* Remove printing during tests * Fix macro annotation warnings * Remove failing links from spark * Return printed as debug logs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes Scala compiler warnings due to bad links in docs and types for macros. It also removes printing during tests or switches it to debug messages. Contains a part of #13995.
@lanking520 @andrewfayres
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.