Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Upgrade Pylint version to 2.3.1 #14807

Merged
merged 8 commits into from
May 1, 2019

Conversation

stu1130
Copy link
Contributor

@stu1130 stu1130 commented Apr 26, 2019

Description

  1. upgrade the default make pylint to use python3 pylint instead of python2 since pylint 2.0 only support python2 link
  2. suppressed most of the pylint error for now and raised a issue to track Pylint Error Fixes #14851
  3. fixes consider-using-in & useless-return

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

Comments

@vandanavk

Copy link
Member

@wkcn wkcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update! LGTM

Copy link
Contributor

@vandanavk vandanavk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roywei
Copy link
Member

roywei commented Apr 29, 2019

@mxnet-label-bot add [CI, Python]

Copy link
Contributor

@sandeep-krishnamurthy sandeep-krishnamurthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM.

@sandeep-krishnamurthy
Copy link
Contributor

Waiting for CI.

@sandeep-krishnamurthy sandeep-krishnamurthy added the pr-awaiting-merge Review and CI is complete. Ready to Merge label Apr 30, 2019
@eric-haibin-lin
Copy link
Member

Thanks. Comments addressed

@sandeep-krishnamurthy sandeep-krishnamurthy merged commit 5e5a59e into apache:master May 1, 2019
access2rohit pushed a commit to access2rohit/incubator-mxnet that referenced this pull request May 14, 2019
* upgrade pylint to latest version & change the Makefile to use python3 pylint

* fix pylint when upgrade

* specify the pylint version

* suppress the pylint not-callable bug

* remove pylint from python2

* fix the typo

* upgrade cpp-package pylint

* move pylint disable to each block
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
* upgrade pylint to latest version & change the Makefile to use python3 pylint

* fix pylint when upgrade

* specify the pylint version

* suppress the pylint not-callable bug

* remove pylint from python2

* fix the typo

* upgrade cpp-package pylint

* move pylint disable to each block
@marcoabreu marcoabreu mentioned this pull request Nov 14, 2019
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI pr-awaiting-merge Review and CI is complete. Ready to Merge Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants