This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkcn
approved these changes
Apr 26, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the update! LGTM
marcoabreu
reviewed
Apr 26, 2019
vandanavk
approved these changes
Apr 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mxnet-label-bot add [CI, Python] |
sandeep-krishnamurthy
approved these changes
Apr 30, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM.
Waiting for CI. |
sandeep-krishnamurthy
added
the
pr-awaiting-merge
Review and CI is complete. Ready to Merge
label
Apr 30, 2019
Thanks. Comments addressed |
access2rohit
pushed a commit
to access2rohit/incubator-mxnet
that referenced
this pull request
May 14, 2019
* upgrade pylint to latest version & change the Makefile to use python3 pylint * fix pylint when upgrade * specify the pylint version * suppress the pylint not-callable bug * remove pylint from python2 * fix the typo * upgrade cpp-package pylint * move pylint disable to each block
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
* upgrade pylint to latest version & change the Makefile to use python3 pylint * fix pylint when upgrade * specify the pylint version * suppress the pylint not-callable bug * remove pylint from python2 * fix the typo * upgrade cpp-package pylint * move pylint disable to each block
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
make pylint
to use python3 pylint instead of python2 since pylint 2.0 only support python2 linkChecklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments
@vandanavk