-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[Clojure] Remove unneeded test files #14813
[Clojure] Remove unneeded test files #14813
Conversation
@Chouffe please take a look 👀 |
Should we add those two files in the .gitignore - similar to what we do for the following files:
|
Also, not sure how to deal with @kedarbellare great feedback
Should we open issues for the things that were not done yet an tackle them in a subsequent PR? @gigasquid and @kedarbellare? Also, I would like to see some actual unit tests for the generated random and sample functions in the 2 new namespaces. Let me know how we should proceed :) |
@Chouffe the adding the file to .gitignore is a great idea. I'm totally cool with opening issues new PR to address the rest of the feedback from @kedarbellare as long as he is cool with it :) |
+1 to adding the For the (import '(org.apache.mxnet NDArrayOrScalar))
;; this calls random_exponential
(util/coerce-return
(NDArrayRandomAPI/exponential
(util/->option 1.0) ; lam
(util/->option (mx-shape/->shape [2 1])) ; shape
(util/->option nil) ; ctx
(util/->option nil) ; dtype
(util/->option nil) ; out
(NDArrayOrScalar. true) ; input lambda is ndarray or scalar?
nil ; class type
))
;; returns 2 x 1 randomly sampled ndarray
;; this calls sample_exponential (concurrent sampling)
(util/coerce-return
(NDArrayRandomAPI/exponential
(util/->option (ndarray/ones [3])) ; lam
(util/->option (mx-shape/->shape [2 1])) ; shape
(util/->option nil) ; ctx
(util/->option nil) ; dtype
(util/->option nil) ; out
(NDArrayOrScalar. false) ; input lambda is ndarray or scalar?
nil ; class type
))
;; returns 3 x 2 x 1 concurrently sampled ndarray you can ignore my comment about unifying random/sample or come up with the clojure way of doing this (e.g. using doing it in a subsequent PR is fine by me 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm (adding it to .gitignore
would be great!)
alright then! @gigasquid you can add the files in the |
@mxnet-label-bot add[Clojure, Test] |
b7f6cfb
to
4ad5997
Compare
* remove unneeded test files * add test files to gitignore
* remove unneeded test files * add test files to gitignore
Description
Removes unneeded test files from #14800
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.