Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Add cpu implementation for Deformable PSROIPooling #14886

Merged
merged 10 commits into from
May 24, 2019
Merged

Add cpu implementation for Deformable PSROIPooling #14886

merged 10 commits into from
May 24, 2019

Conversation

arcadiaphy
Copy link
Member

@arcadiaphy arcadiaphy commented May 6, 2019 •
edited
Loading

Description

As title.

Also code style is refactored to pass lint; index_t is used in tensor size and indexing.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@anirudhacharya
Copy link
Member

@mxnet-label-bot add [pr-awaiting-review]

@marcoabreu marcoabreu added the pr-awaiting-review PR is waiting for code review label May 6, 2019
@arcadiaphy arcadiaphy requested a review from wkcn May 24, 2019 08:24
@arcadiaphy
Copy link
Member Author

@wkcn can you have a look on this PR, too. It's very similar to the PR on Deformable Convolution. Thanks!

wkcn
wkcn approved these changes May 24, 2019
View reviewed changes
Copy link
Member

@wkcn wkcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! LGTM.
Thank you!

@arcadiaphy arcadiaphy merged commit eb0b8af into apache:master May 24, 2019
@arcadiaphy arcadiaphy deleted the pr_deform_psroi branch May 24, 2019 16:21
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
@arcadiaphy
Add cpu implementation for Deformable PSROIPooling (apache#14886)
ca6920e 
* add cpu deformable_psroi_pooling forward

* add cpu deformable_psroi_pooling backward

* add consistency checks

* fix nullptr

* fix code style

* fix lint

* fix code style

* update to index_t

* fix lint

* fix compile
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wkcn wkcn wkcn approved these changes

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arcadiaphy @anirudhacharya @wkcn @marcoabreu