-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Adds additional CUDA build environments #14909
Adds additional CUDA build environments #14909
Conversation
2bcb467
to
f103379
Compare
@mxnet-label-bot add [pr-work-in-progress, CI] |
@mxnet-label-bot remove [pr-work-in-progress] |
@mxnet-label-bot add [pr-awaiting-review] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General feedback, is there any plan to test the cu80 cu90 cu92 docker build?
@lanking520 Not at the moment. Although, I do test them in our release automation pipelines. Having them here not only ensures the build environment follows the code, but also gives developers an easy way to build against these cuda versions (e.g. with ci/build.py). Doesn't mean that we couldn't test against these in CI though...and this would be the first step for that ^^ |
@lanking520 I will also need to backport these to v1.4.x - due to release automation =S |
* Adds additional cuda environments * Removes ubuntu_gpu environment and refactors CI steps to use ubuntu_gpu_cu100 instead
* Adds additional cuda environments * Removes ubuntu_gpu environment and refactors CI steps to use ubuntu_gpu_cu100 instead
Description
This PR adds additional CUDA build environments for use by developers as well as CI and CD job.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Adds CUDA build environments for CUDA versions 8.0, 9.0, 9.2, and 10.0
Comments
I've deleted the Dockerfile.build.ubuntu_gpu environment and created a symlink from Dockerfile.build.ubuntu_gpu -> Dockerfile.build.ubuntu_gpu_cu100