Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Adds additional CUDA build environments #14909

Merged
merged 2 commits into from
May 8, 2019

Conversation

perdasilva
Copy link
Contributor

Description

This PR adds additional CUDA build environments for use by developers as well as CI and CD job.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

Adds CUDA build environments for CUDA versions 8.0, 9.0, 9.2, and 10.0

Comments

I've deleted the Dockerfile.build.ubuntu_gpu environment and created a symlink from Dockerfile.build.ubuntu_gpu -> Dockerfile.build.ubuntu_gpu_cu100

@perdasilva perdasilva force-pushed the add_additional_cuda_build_envs branch from 2bcb467 to f103379 Compare May 7, 2019 18:07
@perdasilva perdasilva changed the title Adds additional CUDA build environments [WIP]Adds additional CUDA build environments May 7, 2019
@vandanavk
Copy link
Contributor

@mxnet-label-bot add [pr-work-in-progress, CI]

@marcoabreu marcoabreu added CI pr-work-in-progress PR is still work in progress labels May 7, 2019
@perdasilva perdasilva changed the title [WIP]Adds additional CUDA build environments Adds additional CUDA build environments May 7, 2019
@perdasilva
Copy link
Contributor Author

@mxnet-label-bot remove [pr-work-in-progress]

@marcoabreu marcoabreu removed the pr-work-in-progress PR is still work in progress label May 8, 2019
@perdasilva
Copy link
Contributor Author

@mxnet-label-bot add [pr-awaiting-review]

@marcoabreu marcoabreu added the pr-awaiting-review PR is waiting for code review label May 8, 2019
@szha szha requested a review from lanking520 May 8, 2019 06:15
Copy link
Member

@lanking520 lanking520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General feedback, is there any plan to test the cu80 cu90 cu92 docker build?

@perdasilva
Copy link
Contributor Author

perdasilva commented May 8, 2019

@lanking520 Not at the moment. Although, I do test them in our release automation pipelines. Having them here not only ensures the build environment follows the code, but also gives developers an easy way to build against these cuda versions (e.g. with ci/build.py).

Doesn't mean that we couldn't test against these in CI though...and this would be the first step for that ^^

@perdasilva
Copy link
Contributor Author

perdasilva commented May 8, 2019

@lanking520 I will also need to backport these to v1.4.x - due to release automation =S

@marcoabreu marcoabreu merged commit 2e03e9f into apache:master May 8, 2019
@perdasilva perdasilva deleted the add_additional_cuda_build_envs branch May 8, 2019 18:13
access2rohit pushed a commit to access2rohit/incubator-mxnet that referenced this pull request May 14, 2019
* Adds additional cuda environments

* Removes ubuntu_gpu environment and refactors CI steps to use ubuntu_gpu_cu100 instead
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
* Adds additional cuda environments

* Removes ubuntu_gpu environment and refactors CI steps to use ubuntu_gpu_cu100 instead
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants