Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

use mx.context.num_gpus instead of mx.test_utils.list_gpus in MF reco… #14926

Merged
merged 1 commit into from
May 14, 2019
Merged

use mx.context.num_gpus instead of mx.test_utils.list_gpus in MF reco… #14926

merged 1 commit into from
May 14, 2019

Conversation

larroy
Copy link
Contributor

@larroy larroy commented May 9, 2019

Description

use mx.context.num_gpus instead of mx.test_utils.list_gpus in MF recommender example

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@larroy larroy requested a review from szha as a code owner May 9, 2019 15:48
@vandanavk
Copy link
Contributor

@mxnet-label-bot add [pr-awaiting-review, Example]

LGTM

@marcoabreu marcoabreu added Example pr-awaiting-review PR is waiting for code review labels May 9, 2019
wkcn
wkcn approved these changes May 12, 2019
View reviewed changes
Copy link
Member

@wkcn wkcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@wkcn wkcn merged commit 3122548 into apache:master May 14, 2019
@wkcn
Copy link
Member

wkcn commented May 14, 2019

Merged. Thank you! : )

larroy added a commit to larroy/mxnet that referenced this pull request May 14, 2019
@larroy
Change mx_test_utils.list_gpus to mx.context.num_gpus where possible
4c4c495 
apache#14926
@larroy larroy mentioned this pull request May 14, 2019
Merged
5 tasks
larroy added a commit to larroy/mxnet that referenced this pull request May 15, 2019
@larroy
Change mx_test_utils.list_gpus to mx.context.num_gpus where possible
47b44d7 
apache#14926
larroy added a commit to larroy/mxnet that referenced this pull request May 17, 2019
@larroy
Change mx_test_utils.list_gpus to mx.context.num_gpus where possible
9e9c5cd 
apache#14926
larroy added a commit to larroy/mxnet that referenced this pull request May 21, 2019
@larroy
Change mx_test_utils.list_gpus to mx.context.num_gpus where possible
13828ef 
apache#14926
@haojin2 haojin2 mentioned this pull request May 22, 2019
Merged
5 tasks
larroy added a commit to larroy/mxnet that referenced this pull request May 23, 2019
@larroy
Change mx_test_utils.list_gpus to mx.context.num_gpus where possible
c50042b 
apache#14926
larroy added a commit to larroy/mxnet that referenced this pull request May 24, 2019
@larroy
Change mx_test_utils.list_gpus to mx.context.num_gpus where possible
d03501a 
apache#14926
szha pushed a commit that referenced this pull request May 30, 2019
@larroy @szha
Change mx.test_utils.list_gpus to mx.context.num_gpus where possible (#…
e9a5a0a 
…14946)

* Change mx_test_utils.list_gpus to mx.context.num_gpus where possible
#14926

* Remove mx.test_utils.list_gpus

* revert accidental unrelated dmlc-core changes

* Fix basic_layers.py import

* Fix typo

* restore list_gpus() in tests_utils for compat

* restore dmlc-core
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
@larroy
use mx.context.num_gpus instead of mx.test_utils.list_gpus in MF reco…
0f11f99 
…mmender example (apache#14926)
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
@larroy
Change mx.test_utils.list_gpus to mx.context.num_gpus where possible (a…
32f176e 
…pache#14946)

* Change mx_test_utils.list_gpus to mx.context.num_gpus where possible
apache#14926

* Remove mx.test_utils.list_gpus

* revert accidental unrelated dmlc-core changes

* Fix basic_layers.py import

* Fix typo

* restore list_gpus() in tests_utils for compat

* restore dmlc-core
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wkcn wkcn wkcn approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
Example pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@larroy @vandanavk @wkcn @marcoabreu