Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

add ctx argument for rand_ndarray and rand_sparse_ndarray test util funcs #14966

Merged
merged 1 commit into from
May 18, 2019

Conversation

haojin2
Copy link
Contributor

@haojin2 haojin2 commented May 15, 2019

Description

As title. Improve usability of those 2 test utilities functions. Previously one has to do something like:

a = rand_ndarray(shape, stype, density).as_in_context(ctx)

With this change one only need to:

a = rand_ndarray(shape, stype, density, ctx)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Add ctx argument for rand_ndarray and rand_sparse_ndarray functions

Comments

Don't think this needs a dedicated unit test, but still got one small script in place to verify correctness of the change:

import mxnet as mx
from mxnet.test_utils import rand_ndarray

shape = (1000, 1000)
a = rand_ndarray(shape, stype='default')
print(a.context)
b = rand_ndarray(shape, stype='csr', density=0.01)
print(b.context)
c = rand_ndarray(shape, stype='row_sparse', density=0.01)
print(c.context)
ctx = mx.gpu(1)
a = rand_ndarray(shape, stype='default', ctx=ctx)
print(a.context)
b = rand_ndarray(shape, stype='csr', density=0.01, ctx=ctx)
print(b.context)
c = rand_ndarray(shape, stype='row_sparse', density=0.01, ctx=ctx)
print(c.context)

Result of running this script:

cpu(0)
cpu(0)
cpu(0)
gpu(1)
gpu(1)
gpu(1)

@haojin2 haojin2 added Python pr-awaiting-review PR is waiting for code review labels May 15, 2019
@haojin2 haojin2 self-assigned this May 15, 2019
@haojin2 haojin2 force-pushed the rand_ndarray_ctx branch 3 times, most recently from ace3a21 to 0c806e6 Compare May 17, 2019 04:53
@eric-haibin-lin eric-haibin-lin merged commit a7e7cdc into apache:master May 18, 2019
@haojin2 haojin2 deleted the rand_ndarray_ctx branch May 20, 2019 07:38
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants