Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Flaky Test] Fixes flaky TensorRT Test #15014

Merged
merged 1 commit into from
May 24, 2019

Conversation

perdasilva
Copy link
Contributor

@perdasilva perdasilva commented May 21, 2019

Description

Related to #14978

Experienced TensorRT test suite failure:

======================================================================
FAIL: Run LeNet-5 inference comparison between MXNet and TensorRT.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/nose/case.py", line 198, in runTest
    self.test(*self.arg)
  File "/work/mxnet/tests/python/tensorrt/test_tensorrt_lenet5.py", line 100, in test_tensorrt_inference
    MXNet = %f, TensorRT = %f""" % (mx_pct, trt_pct)
AssertionError: Diff. between MXNet & TensorRT accuracy too high:
           MXNet = 99.050000, TensorRT = 99.060000

See logs for full details.

I've decreased the sensitivity of the test slightly and modified the error message a little for clarity.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@perdasilva perdasilva changed the title Fixes flaky TensorRT Test [Flaky Test] Fixes flaky TensorRT Test May 21, 2019
@karan6181
Copy link
Contributor

@mxnet-label-bot add [Python, Test, pr-awaiting-review]

@perdasilva
Copy link
Contributor Author

I've executed the test 10k times and didn't see it happen.

@wkcn wkcn merged commit 5763ba9 into apache:master May 24, 2019
@wkcn
Copy link
Member

wkcn commented May 24, 2019

Merged. Thank you for the fix!

@perdasilva perdasilva deleted the fix_flaky_tensorrt_test branch May 24, 2019 05:37
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review Python Test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants