This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
GPU RNN to use TempSpace resource for workspace. #15056
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR eliminates the test flakiness described in #15034 (non-deterministic low-probability test_operator_gpu.py:test_rnntanh_bidirectional failures on P40)
The fix was to move the cudnn workspace from a per-op-instance permanent allocation to use the shared TempSpace resource. Note that for temporary additional workspace, operators typically request space from the shared global TempSpace resource that is maintained for each gpu worker. This was in fact the approach taken by cudnn_rnn-inl.h before it was combined with rnn-inl.h by #14476. So in a sense, this PR simply reverts the portion of the 14476 PR that correlates with the flakiness, a much better result than having to revert the entire PR.
Some minor code cleanup was performed around now-unused RNNOp data members
dropout_states_
anddropout_bytes_
.@Shza @lihaofd @ptrendx
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments