Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

include stdint.h in c_api.h since uint64_t is not defined #1544

Merged
merged 2 commits into from
Feb 29, 2016

Conversation

hjk41
Copy link
Contributor

@hjk41 hjk41 commented Feb 29, 2016

No description provided.

hjk41 added a commit that referenced this pull request Feb 29, 2016
include stdint.h in c_api.h since uint64_t is not defined
@hjk41 hjk41 merged commit febd9ab into apache:master Feb 29, 2016
@tqchen
Copy link
Member

tqchen commented Feb 29, 2016

I think we need to be a bit careful about this. It depends on availability of stdint.
The original idea is to only use mx_uint and mx_ulong for parameter passing. Maybe consider change the uint64_t type to these types are more approperiate

@hjk41
Copy link
Contributor Author

hjk41 commented Mar 1, 2016

ok... I will make another PR to change it to mx_ulong

On Tue, Mar 1, 2016 at 12:41 AM, Tianqi Chen notifications@github.com
wrote:

I think we need to be a bit careful about this. It depends on availability
of stdint.
The original idea is to only use mx_uint and mx_ulong for parameter
passing. Maybe consider change the uint64_t type to these types are more
approperiate


Reply to this email directly or view it on GitHub
#1544 (comment).

HONG Chuntao
System Research Group
Microsoft Research Asia

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants