Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Remove python2 from CI #15990

Merged
merged 23 commits into from
Feb 3, 2020
Merged

Remove python2 from CI #15990

merged 23 commits into from
Feb 3, 2020

Conversation

larroy
Copy link
Contributor

@larroy larroy commented Aug 24, 2019

Description

This PR removes Python2 test from CI.

See:

https://lists.apache.org/list.html?dev@mxnet.apache.org:lte=1M:python2

From now on Python2 compatibility won't be tested and thus we no longer actively support Python2.

@larroy
Copy link
Contributor Author

larroy commented Aug 24, 2019

@mxnet-label-bot add [pr-work-in-progress]

@marcoabreu marcoabreu added the pr-work-in-progress PR is still work in progress label Aug 24, 2019
@larroy
Copy link
Contributor Author

larroy commented Aug 24, 2019

@mxnet-label-bot add [ci]

@marcoabreu marcoabreu added the CI label Aug 24, 2019
@marcoabreu
Copy link
Contributor

The community has not agreed on deprecating python2 immediately.

@marcoabreu marcoabreu closed this Aug 24, 2019
@larroy
Copy link
Contributor Author

larroy commented Aug 26, 2019

It's a WIP, maybe not closing?

@marcoabreu
Copy link
Contributor

It's still a few releases down the road, so no need to put in effort at the moment. It might just send the wrong signals.

@leezu leezu reopened this Jan 23, 2020
@leezu
Copy link
Contributor

leezu commented Jan 23, 2020

Re-open as per consensus in https://lists.apache.org/thread.html/r3a2db0f22a1680cc56804191446fef2289595798ca19fd17de1ff03e%40%3Cdev.mxnet.apache.org%3E

@larroy would you like to rebase and fix conflicts?

ci/docker/runtime_functions.sh Outdated Show resolved Hide resolved
@larroy
Copy link
Contributor Author

larroy commented Jan 28, 2020

@mxnet-label-bot remove [pr-work-in-progress]

@lanking520 lanking520 removed the pr-work-in-progress PR is still work in progress label Jan 28, 2020
@larroy
Copy link
Contributor Author

larroy commented Jan 28, 2020

@mxnet-label-bot add [pr-awaiting-merge]

@lanking520 lanking520 added the pr-awaiting-merge Review and CI is complete. Ready to Merge label Jan 28, 2020
Copy link
Contributor

@leezu leezu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Submodule ps-lite is incorrectly updated as part of conflict resolution. Or is it a bug in Github UI?

Copy link
Contributor

@leezu leezu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@eric-haibin-lin eric-haibin-lin mentioned this pull request Jan 29, 2020
7 tasks
@@ -21,6 +21,7 @@
# the whole docker cache for the image

set -ex
perl -pi -e 's/archive.ubuntu.com/us-west-2.ec2.archive.ubuntu.com/' /etc/apt/sources.list
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this going to do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use the AWS mirror instead of the default ubuntu one, making docker rebuild significantly faster.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make this conditional?

@larroy
Copy link
Contributor Author

larroy commented Jan 30, 2020

That will cause performance issues if run outside of CI. Maybe not replace? Also, unrelated change

Can be removed before merge. Many CI failures now that require rebuild. Can also have a conditional on being in EC2.

@marcoabreu
Copy link
Contributor

Conditional sounds good

@leezu leezu merged commit 7caffa6 into apache:master Feb 3, 2020
szha added a commit to szha/mxnet that referenced this pull request Feb 8, 2020
szha added a commit to szha/mxnet that referenced this pull request Feb 11, 2020
szha added a commit to szha/mxnet that referenced this pull request Feb 12, 2020
szha added a commit to szha/mxnet that referenced this pull request Feb 13, 2020
szha added a commit that referenced this pull request Feb 14, 2020
zheyuye pushed a commit to zheyuye/incubator-mxnet that referenced this pull request Feb 19, 2020
zheyuye pushed a commit to zheyuye/incubator-mxnet that referenced this pull request Feb 19, 2020
leezu added a commit to leezu/mxnet that referenced this pull request Mar 5, 2020
Fixes regression introduced by
apache#15990
@leezu leezu mentioned this pull request Mar 5, 2020
leezu added a commit that referenced this pull request Mar 5, 2020
* Fix cd/mxnet_lib/dynamic/Jenkins_pipeline.groovy

Fixes a regression in CD introduced by
#17645

* Fix whitespace

* Add NATIVE_ADDITIONAL.md

Fixes a regression in CD introduced by
#16899

* Update other $TYPE_ADDITIONAL.MD

* Fix cd/python/docker

Fixes regression introduced by
#15990
ChaiBapchya pushed a commit to ChaiBapchya/mxnet that referenced this pull request Apr 8, 2020
MoisesHer pushed a commit to MoisesHer/incubator-mxnet that referenced this pull request Apr 10, 2020
* Fix cd/mxnet_lib/dynamic/Jenkins_pipeline.groovy

Fixes a regression in CD introduced by
apache#17645

* Fix whitespace

* Add NATIVE_ADDITIONAL.md

Fixes a regression in CD introduced by
apache#16899

* Update other $TYPE_ADDITIONAL.MD

* Fix cd/python/docker

Fixes regression introduced by
apache#15990
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request May 29, 2020
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request May 29, 2020
* Fix cd/mxnet_lib/dynamic/Jenkins_pipeline.groovy

Fixes a regression in CD introduced by
apache#17645

* Fix whitespace

* Add NATIVE_ADDITIONAL.md

Fixes a regression in CD introduced by
apache#16899

* Update other $TYPE_ADDITIONAL.MD

* Fix cd/python/docker

Fixes regression introduced by
apache#15990
mseth10 pushed a commit to mseth10/incubator-mxnet that referenced this pull request Jun 2, 2020
* Fix cd/mxnet_lib/dynamic/Jenkins_pipeline.groovy

Fixes a regression in CD introduced by
apache#17645

* Fix whitespace

* Add NATIVE_ADDITIONAL.md

Fixes a regression in CD introduced by
apache#16899

* Update other $TYPE_ADDITIONAL.MD

* Fix cd/python/docker

Fixes regression introduced by
apache#15990
mseth10 pushed a commit to mseth10/incubator-mxnet that referenced this pull request Jun 2, 2020
* Fix cd/mxnet_lib/dynamic/Jenkins_pipeline.groovy

Fixes a regression in CD introduced by
apache#17645

* Fix whitespace

* Add NATIVE_ADDITIONAL.md

Fixes a regression in CD introduced by
apache#16899

* Update other $TYPE_ADDITIONAL.MD

* Fix cd/python/docker

Fixes regression introduced by
apache#15990
leezu added a commit that referenced this pull request Jun 9, 2020
* Fix CD (#17776)

* Fix cd/mxnet_lib/dynamic/Jenkins_pipeline.groovy

Fixes a regression in CD introduced by
#17645

* Fix whitespace

* Add NATIVE_ADDITIONAL.md

Fixes a regression in CD introduced by
#16899

* Update other $TYPE_ADDITIONAL.MD

* Fix cd/python/docker

Fixes regression introduced by
#15990

* [CD] update pypi description, setup.py (#17681)

* update pypi description, setup.py, use manylinux2010, use unified dist link for nightly

* Use manylinux2014

Co-authored-by: Leonard Lausen <leonard@lausen.nl>

* reverting .so path as per MAKE flow

Co-authored-by: Leonard Lausen <lausen@amazon.com>
Co-authored-by: Sheng Zha <szha@users.noreply.github.com>
Co-authored-by: Leonard Lausen <leonard@lausen.nl>
leezu added a commit that referenced this pull request Jun 15, 2020
* Fix CD (#17776)

* Fix cd/mxnet_lib/dynamic/Jenkins_pipeline.groovy

Fixes a regression in CD introduced by
#17645

* Fix whitespace

* Add NATIVE_ADDITIONAL.md

Fixes a regression in CD introduced by
#16899

* Update other $TYPE_ADDITIONAL.MD

* Fix cd/python/docker

Fixes regression introduced by
#15990

* [CD] update pypi description, setup.py (#17681)

* update pypi description, setup.py, use manylinux2010, use unified dist link for nightly

* Use manylinux2014

Co-authored-by: Leonard Lausen <leonard@lausen.nl>

* reverting .so path as per MAKE flow

Co-authored-by: Leonard Lausen <lausen@amazon.com>
Co-authored-by: Sheng Zha <szha@users.noreply.github.com>
Co-authored-by: Leonard Lausen <leonard@lausen.nl>
ChaiBapchya pushed a commit to ChaiBapchya/mxnet that referenced this pull request Aug 15, 2020
* Fix CD (apache#17776)

* Fix cd/mxnet_lib/dynamic/Jenkins_pipeline.groovy

Fixes a regression in CD introduced by
apache#17645

* Fix whitespace

* Add NATIVE_ADDITIONAL.md

Fixes a regression in CD introduced by
apache#16899

* Update other $TYPE_ADDITIONAL.MD

* Fix cd/python/docker

Fixes regression introduced by
apache#15990

* [CD] update pypi description, setup.py (apache#17681)

* update pypi description, setup.py, use manylinux2010, use unified dist link for nightly

* Use manylinux2014

Co-authored-by: Leonard Lausen <leonard@lausen.nl>

* reverting .so path as per MAKE flow

Co-authored-by: Leonard Lausen <lausen@amazon.com>
Co-authored-by: Sheng Zha <szha@users.noreply.github.com>
Co-authored-by: Leonard Lausen <leonard@lausen.nl>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants