Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

set no_bias in deconv layer in fcnxs example #1627

Merged
merged 1 commit into from
Mar 28, 2016
Merged

Conversation

zhaw
Copy link
Contributor

@zhaw zhaw commented Mar 13, 2016

In recent update, deconvolution layer got bias parameter but this example hasn't been updated yet. If you run this example now, it returns an error. #1619

@zhaw zhaw changed the title add deconv layer bias param add deconv layer bias param in fcnxs example Mar 13, 2016
@tqchen
Copy link
Member

tqchen commented Mar 13, 2016

@tornadomeet

@tornadomeet
Copy link
Contributor

@zhaw thanks for pointing this out.
@tqchen ,becasue in deconvolution operator, we generally not use the bias term, so in my original implemention of deconvolution, the default setting is use no bias(like caffe), but @piiswrong has changed the default setting 27a3382 (which i do not agree )
@zhaw so you can refer #1477.
and could you please update this pr not to add bias term in deconv(beacuase it used for upsampling), we only need to change symbol_fcnxs.py in which add no_bias=True in all Deconvolution?
such as https://github.com/dmlc/mxnet/blob/master/example/fcn-xs/symbol_fcnxs.py#L140 https://github.com/dmlc/mxnet/blob/master/example/fcn-xs/symbol_fcnxs.py#L160 https://github.com/dmlc/mxnet/blob/master/example/fcn-xs/symbol_fcnxs.py#L175 https://github.com/dmlc/mxnet/blob/master/example/fcn-xs/symbol_fcnxs.py#L182
and do not change init_fcnxs.py, thanks!

@zhaw zhaw changed the title add deconv layer bias param in fcnxs example set no_bias in deconv layer in fcnxs example Mar 14, 2016
@zhaw
Copy link
Contributor Author

zhaw commented Mar 14, 2016

@tornadomeet thanks for your explanation!

@piiswrong
Copy link
Contributor

@tornadomeet I think we can change deconv back to no_bias =true for default.

BTW, is the gradient correctly computed for bias in deconv?

@tornadomeet
Copy link
Contributor

@piiswrong yes, when using bias in deconv, i think the gradient is computed correctly.
@zhaw so with agreed with @piiswrong , could you help do this: change the default no_bias setting from false to true in deconv, which in https://github.com/dmlc/mxnet/blob/master/src/operator/deconvolution-inl.h#L52 ? Then we will not need to change any code in the fcn-xs example. thank you for your patience!

@zhaw
Copy link
Contributor Author

zhaw commented Mar 14, 2016

@tornadomeet no problem, glad I can help.

@tqchen
Copy link
Member

tqchen commented Mar 20, 2016

is this PR good to be merged. please squash the commits as in http://mxnet.readthedocs.org/en/latest/contribute.html#how-to-combine-multiple-commits-into-one

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants