Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

disable tests #16536

Merged
merged 2 commits into from
Oct 18, 2019
Merged

disable tests #16536

merged 2 commits into from
Oct 18, 2019

Conversation

roywei
Copy link
Member

@roywei roywei commented Oct 18, 2019

Description

#16535
#16524

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

Copy link
Contributor

@haojin2 haojin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roywei roywei merged commit 32bb374 into apache:master Oct 18, 2019
@roywei
Copy link
Member Author

roywei commented Oct 18, 2019

Thanks @haojin2 for analysis on the kv-store test timeout, put it here for future reference.

The dist kvstore build fails due to OOM error on GPUs, previously it was testing 7 workers, now each worker consumes more than 1G of memory and that used up all GPU memory on the g3.8x instances used by CI, now suggesting to reduce the # of workers to 4 so that we test within the capacity of the test instanecs instead of totally disabling it.

@marcoabreu
Copy link
Contributor

Well at that point we can also disable it instead of showing a false green check mark

@roywei roywei deleted the disable_tests branch January 29, 2020 19:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants