This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Miscellaneous fix for several numpy issues #16664
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sxjscience
reviewed
Oct 29, 2019
reminisce
reviewed
Oct 29, 2019
haojin2
commented
Oct 29, 2019
marcoabreu
reviewed
Oct 30, 2019
marcoabreu
reviewed
Oct 30, 2019
@eric-haibin-lin Good for merge? |
reminisce
approved these changes
Oct 31, 2019
yajiedesign
pushed a commit
to yajiedesign/mxnet
that referenced
this pull request
Nov 6, 2019
* fix behavior of np.array when given official numpy ndarray * bool for expand_dims and cast * recover original Makefile * address comments * add boolean support for cumsum * add gpu cast boolean support * add error message
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#16658 #16650 and inconsistent type when an array is created from an official numpy array:
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
expand_dims
's boolean supportComments