This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Enforces NDArray type in get_symbol #16871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you make the error message a little bit more clear (like adding "Incorrect type of the argument" or something like that?) |
Kh4L
force-pushed
the
get_symbol_type_check
branch
from
eed2355
to
f4adaa9
Compare
Done |
Signed-off-by: Serge Panev <spanev@nvidia.com>
Kh4L
force-pushed
the
get_symbol_type_check
branch
from
f4adaa9
to
ffce8bf
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Giving a Python object different than NDArray to
get_symbolcauses a Segfault, we need to enforce the type.Add an assert for type checking.
Checklist
Essentials
Changes