This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Fix ndarray indexing bug #16895
Merged
Fix ndarray indexing bug #16895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrendx
reviewed
Nov 25, 2019
|
@szha Can we get this reviewed today? @reminisce Since the repro in #16647 is small, can we add a test with it to make sure the original issue is (and stays) actually fixed? |
reminisce
force-pushed
the
fix_ndarray_indexing_16647
branch
from
3c1ea90
to
7628256
Compare
|
@PatricZhao @TaoLv MKLDNN CPP test keeps failing on |
This was referenced Nov 26, 2019
|
@reminisce I have created a PR to revert the problematic commit. Sorry for the inconvenience. |
|
@reminisce could you merge with the latest master to pick up this fix for the cpp test? |
reminisce
force-pushed
the
fix_ndarray_indexing_16647
branch
from
7628256
to
34940cc
Compare
|
Build failed due to network error - I retriggered it. |
|
Ubuntu 14.04 has problems. It's being under investigation. |
reminisce
force-pushed
the
fix_ndarray_indexing_16647
branch
from
34940cc
to
0e7dbef
Compare
reminisce
force-pushed
the
fix_ndarray_indexing_16647
branch
from
0e7dbef
to
604d9bd
Compare
ptrendx
pushed a commit
to ptrendx/mxnet
that referenced
this pull request
Dec 9, 2019
* Fix indexing bug * More test cases * Add test from 16647
ptrendx
added a commit
that referenced
this pull request
Dec 10, 2019
* Fix ndarray indexing bug (#16895) * Fix indexing bug * More test cases * Add test from 16647 * [Gluon] Update contrib.Estimator LoggingHandler to support logging per batch interval (#16922) * Update LoggingHandler to support logging per interval * Fix the constant variable issue in the logging handler * Remove the constant variable hack in the logging handler. * 1) replace LOG_PER_BATCH with LOG_PER_INTERVAL 2) add test case * Improve the test script for LoggingHandler * small fix on the test script * logging handler test case bug fix * remove parameter verbose from LoggingHandler * move log_interval to the first argument * resolve unittest mistakes * Add micro averaging strategy to pearsonr metric (#16878) Strategy to be used for aggregating across mini-batches. "macro": average the pearsonr scores for each batch. "micro": compute a single pearsonr score across all batches. * [Bugfix] [Numpy] Add `kAddTo` and kNullOp to Transpose (#16979) * update Check for repeated axes enable addto to transpose fix fix fix fix remove unused ndim Update pseudo2DTranspose_op-inl.cuh Update pseudo2DTranspose_op-inl.cuh Update pseudo2DTranspose_op-inl.cuh fix Update pseudo2DTranspose_op-inl.cuh try to fix Update pseudo2DTranspose_op-inl.cuh Update pseudo2DTranspose_op-inl.cuh Update pseudo2DTranspose_op-inl.cuh fix Update np_matrix_op.cc Update test_numpy_op.py update test case fix implementation fix bug update fix bug Update pseudo2DTranspose_op-inl.cuh fix fix Update test_numpy_op.py * Fix bug * fix docstring * try to address comment * no need to change this line * Fix bug * address comments * address comment * introduce gradient update handler to the base estimator (#16900) * introduce gradient update handler to the base estimator * Modify the gradient update handler to include the batch size * Remove unrelated gradient update handler. * Modify gradient update handler to take the current batch size. * Remove white space to avoid the sanity check failure * add small tweak to the handler code * Modify the documentation of priority parameter of relevant handlers. * small modification on the documentation. * Add small modification on the documentation. * Remove unnecessary list check
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed #16647
@fhieber