This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tommliu
force-pushed
the
all_any
branch
2 times, most recently
from
December 17, 2019 03:22
d95f6bb
to
1477dfe
Compare
haojin2
reviewed
Dec 17, 2019
haojin2
reviewed
Dec 17, 2019
haojin2
reviewed
Dec 17, 2019
haojin2
reviewed
Dec 17, 2019
Tommliu
force-pushed
the
all_any
branch
4 times, most recently
from
December 19, 2019 06:40
bc4a5f6
to
8cb7bcc
Compare
haojin2
reviewed
Dec 20, 2019
haojin2
reviewed
Dec 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than the only open comment
haojin2
approved these changes
Dec 27, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Numpy operator All/Any
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments