Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

OP All/Any [Numpy] #17087

Merged
merged 1 commit into from
Dec 27, 2019
Merged

OP All/Any [Numpy] #17087

merged 1 commit into from
Dec 27, 2019

Conversation

Tommliu
Copy link
Contributor

@Tommliu Tommliu commented Dec 16, 2019

Description

Numpy operator All/Any

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@Tommliu Tommliu requested a review from szha as a code owner December 16, 2019 09:32
@Tommliu Tommliu force-pushed the all_any branch 2 times, most recently from d95f6bb to 1477dfe Compare December 17, 2019 03:22
@Tommliu Tommliu force-pushed the all_any branch 4 times, most recently from bc4a5f6 to 8cb7bcc Compare December 19, 2019 06:40
Copy link
Contributor

@haojin2 haojin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the only open comment

Copy link
Contributor

@haojin2 haojin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants