This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
refactor gluon.utils.split_data() following np.array_split() #17123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sxjscience
reviewed
Dec 19, 2019
sxjscience
reviewed
Dec 19, 2019
LGTM. We need to add test in https://github.com/apache/incubator-mxnet/blob/master/tests/python/unittest/test_gluon_utils.py. |
sxjscience
reviewed
Dec 19, 2019
@sxjscience There are test cases in https://github.com/apache/incubator-mxnet/blob/f701f3f76a2a2f741c08354c622924344d01f13c/tests/python/unittest/test_gluon.py#L963 already, so I add test against numpy there. |
@zburning Sorry my meaning was to test the mx.np version. Has it been tested somewhere? |
sxjscience
reviewed
Dec 20, 2019
leezu
reviewed
Dec 21, 2019
sxjscience
approved these changes
Dec 31, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
6 tasks
access2rohit
pushed a commit
to access2rohit/incubator-mxnet
that referenced
this pull request
Oct 1, 2020
access2rohit
pushed a commit
to access2rohit/incubator-mxnet
that referenced
this pull request
Oct 1, 2020
access2rohit
pushed a commit
to access2rohit/incubator-mxnet
that referenced
this pull request
Oct 1, 2020
access2rohit
pushed a commit
to access2rohit/incubator-mxnet
that referenced
this pull request
Oct 2, 2020
access2rohit
pushed a commit
to access2rohit/incubator-mxnet
that referenced
this pull request
Oct 2, 2020
4 tasks
access2rohit
pushed a commit
to access2rohit/incubator-mxnet
that referenced
this pull request
Oct 2, 2020
access2rohit
pushed a commit
to access2rohit/incubator-mxnet
that referenced
this pull request
Oct 3, 2020
access2rohit
pushed a commit
to access2rohit/incubator-mxnet
that referenced
this pull request
Oct 3, 2020
samskalicky
pushed a commit
that referenced
this pull request
Oct 3, 2020
Co-authored-by: Rohit Kumar Srivastava <srivastava.141@buckeyemail.osu.edu>
samskalicky
pushed a commit
that referenced
this pull request
Oct 4, 2020
Co-authored-by: Rohit Kumar Srivastava <srivastava.141@buckeyemail.osu.edu>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #17105
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments