Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Numpy] Add linalg.eig/eigh/eigvals/eigvalsh op #17188

Merged
merged 1 commit into from
Feb 3, 2020

Conversation

sjtuWangDing
Copy link
Contributor

Description

Add linalg.eig/eigh/eigvals/eigvalsh op

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@sjtuWangDing sjtuWangDing force-pushed the linalg_eig#eigvals branch 2 times, most recently from a86e7e3 to 3e7fde7 Compare December 28, 2019 11:08
@haojin2 haojin2 added the Numpy label Dec 30, 2019
Copy link
Contributor

@reminisce reminisce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add interoperability test.

tests/python/unittest/test_numpy_op.py Outdated Show resolved Hide resolved
@sjtuWangDing sjtuWangDing force-pushed the linalg_eig#eigvals branch 12 times, most recently from 05e194c to 51bf362 Compare January 20, 2020 02:03
@sjtuWangDing sjtuWangDing force-pushed the linalg_eig#eigvals branch 3 times, most recently from f08a42d to 8ae752b Compare January 29, 2020 16:46
@sjtuWangDing sjtuWangDing force-pushed the linalg_eig#eigvals branch 2 times, most recently from 5e949a9 to 2461a54 Compare February 2, 2020 14:09
* fix pylint

* fix add GpuCallbackCpuImpl
@haojin2 haojin2 merged commit 4f455ef into apache:master Feb 3, 2020
zheyuye pushed a commit to zheyuye/incubator-mxnet that referenced this pull request Feb 19, 2020
* fix pylint

* fix add GpuCallbackCpuImpl
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants