Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[OpPerf] Add Neural network loss ops #17482

Merged
merged 4 commits into from
Feb 3, 2020
Merged

[OpPerf] Add Neural network loss ops #17482

merged 4 commits into from
Feb 3, 2020

Conversation

ChaiBapchya
Copy link
Contributor

@ChaiBapchya ChaiBapchya commented Jan 30, 2020 •
edited
Loading

Description

Added Neural Network loss operators to the existing set of opperf benchmarks

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Added following ops
  1. smooth_l1
  2. CTCLoss [ctc_loss added as alias]
  3. MakeLoss
  4. softmax_cross_entropy

Results

from benchmark.opperf.nd_operations.nn_loss_operators import run_loss_operators_benchmarks
 run_loss_operators_benchmarks()

INFO:root:Begin Benchmark - CTCLoss
INFO:root:Complete Benchmark - CTCLoss
INFO:root:Begin Benchmark - MakeLoss
INFO:root:Complete Benchmark - MakeLoss
INFO:root:Begin Benchmark - ctc_loss
INFO:root:Complete Benchmark - ctc_loss
INFO:root:Begin Benchmark - smooth_l1
INFO:root:Complete Benchmark - smooth_l1
INFO:root:Begin Benchmark - softmax_cross_entropy
INFO:root:Complete Benchmark - softmax_cross_entropy

CPU - https://gist.github.com/ChaiBapchya/fb608c551689d3a4ff48c3be5030a2e2

Comments

@sandeep-krishnamurthy @apeforest @connorgoggins

This was referenced Jan 30, 2020
Open
Open
connorgoggins
connorgoggins reviewed Jan 30, 2020
View reviewed changes
Copy link
Contributor

@connorgoggins connorgoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one small variable name change.

benchmark/opperf/nd_operations/nn_loss_operators.py Outdated Show resolved Hide resolved
benchmark/opperf/nd_operations/nn_loss_operators.py Outdated Show resolved Hide resolved
benchmark/opperf/utils/benchmark_utils.py Show resolved Hide resolved
@ChaiBapchya
Copy link
Contributor Author

GPU : https://gist.github.com/ChaiBapchya/fac7310f7d167d1361854451e7daa342

@ChaiBapchya
Copy link
Contributor Author

@mxnet-label-bot add [pr-awaiting-review]

@lanking520 lanking520 added the pr-awaiting-review PR is waiting for code review label Jan 31, 2020
@ChaiBapchya ChaiBapchya mentioned this pull request Feb 2, 2020
Open
@ChaiBapchya
Copy link
Contributor Author

@mxnet-label-bot add [pr-awaiting-merge]

@lanking520 lanking520 added the pr-awaiting-merge Review and CI is complete. Ready to Merge label Feb 3, 2020
@apeforest apeforest merged commit 88cc54d into apache:master Feb 3, 2020
zheyuye pushed a commit to zheyuye/incubator-mxnet that referenced this pull request Feb 19, 2020
@ChaiBapchya
[OpPerf] Add Neural network loss ops (apache#17482)
dd6a881 
* add loss ops and fix minor typo in array_rearrange

* fix issues with ops, still no backward for softmax_cross_entropy

* fix names

* add profiler param to function description
@ChaiBapchya ChaiBapchya deleted the nn_loss_ops branch June 24, 2020 19:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@connorgoggins connorgoggins connorgoggins left review comments

@apeforest apeforest apeforest approved these changes

@sandeep-krishnamurthy sandeep-krishnamurthy Awaiting requested review from sandeep-krishnamurthy

Assignees
No one assigned
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChaiBapchya @apeforest @connorgoggins @lanking520