Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[OpPerf] Implement remaining GEMM ops #17501

Merged
merged 3 commits into from
Feb 7, 2020

Conversation

connorgoggins
Copy link
Contributor

@connorgoggins connorgoggins commented Feb 1, 2020

Description

This PR serves to implement the remaining operators from the GEMM category in opperf. To achieve this, I added a call to run_performance_test for the khatri_rao op within the run_gemm_operators_benchmarks function and, since khatri_rao has yet to be implemented for GPU, added a check to ensure that the context was GPU before running benchmarks for khatri_rao. Since khatri_rao was the only remaining op in the GEMM ops category, these were the only required changes.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • M benchmark/opperf/nd_operations/gemm_operators.py

Comments

Tested on p2.16xl w/ubuntu 16.04 and Mac OS with:

  1. Checkout branch and call function run_gemm_operators_benchmarks - runs all gemm ops (dot, batch_dot, and khatri_rao) on relevant data
  2. Checkout branch and run opperf.py (full run of all ops)

Performance Results

Group of operator test - all GEMM ops (CPU)
Full OpPerf test (CPU)

Group of operator test - all GEMM ops (GPU)
Full OpPerf test (GPU)

@apeforest @access2rohit @ChaiBapchya

@connorgoggins connorgoggins changed the title [OpPerf] Implement remaining gemm ops [OpPerf] Implement remaining GEMM ops Feb 1, 2020
Copy link
Contributor

@access2rohit access2rohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@connorgoggins
Copy link
Contributor Author

@mxnet-label-bot add [pr-awaiting-review]

@lanking520 lanking520 added the pr-awaiting-review PR is waiting for code review label Feb 1, 2020
Copy link
Contributor

@ChaiBapchya ChaiBapchya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one!

@apeforest apeforest merged commit 6533258 into apache:master Feb 7, 2020
zheyuye pushed a commit to zheyuye/incubator-mxnet that referenced this pull request Feb 19, 2020
* Added run_perf_test call for khatri_rao, added supporting comments

* Disabled khatri_rao on GPU as it has not yet been implemented

* Fixed reference pre-assignment
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request May 29, 2020
* Added run_perf_test call for khatri_rao, added supporting comments

* Disabled khatri_rao on GPU as it has not yet been implemented

* Fixed reference pre-assignment
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants