Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MKLDNN] apply MKLDNNRun to quantized_act/transpose #17689

Merged
merged 2 commits into from
Feb 29, 2020

Conversation

wuxun-zhang
Copy link
Contributor

@wuxun-zhang wuxun-zhang commented Feb 26, 2020

Description

This is a supplementary patch for #16772.
@pengzhao-intel @TaoLv @ZhennanQin @zhreshold

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

Copy link
Contributor

@pengzhao-intel pengzhao-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TaoLv TaoLv merged commit 88b3051 into apache:master Feb 29, 2020
@wuxun-zhang wuxun-zhang deleted the MKLDNNRun_patch branch February 29, 2020 13:25
MoisesHer pushed a commit to MoisesHer/incubator-mxnet that referenced this pull request Apr 10, 2020
* apply MKLDNNRun to quantized_act/transpose ops

* run CI
wuxun-zhang added a commit to wuxun-zhang/incubator-mxnet that referenced this pull request Apr 15, 2020
* apply MKLDNNRun to quantized_act/transpose ops

* run CI
wuxun-zhang added a commit to wuxun-zhang/incubator-mxnet that referenced this pull request Apr 16, 2020
* apply MKLDNNRun to quantized_act/transpose ops

* run CI
wuxun-zhang added a commit to wuxun-zhang/incubator-mxnet that referenced this pull request Apr 16, 2020
* apply MKLDNNRun to quantized_act/transpose ops

* run CI
wuxun-zhang added a commit to wuxun-zhang/incubator-mxnet that referenced this pull request Apr 18, 2020
* apply MKLDNNRun to quantized_act/transpose ops

* run CI
pengzhao-intel pushed a commit that referenced this pull request Apr 18, 2020
* [MKLDNN] apply MKLDNNRun to quantized_act/transpose (#17689)

* apply MKLDNNRun to quantized_act/transpose ops

* run CI

* [MKL-DNN] Integrate Conv3d and Pool3d/1d (#17884)

* Integrate MKl-DNN conv3d and pool3d/1d

* fix UT & address comments

* clean code

* rebase against latest master

* fix conflicts

* fix CI

* rebase
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request May 29, 2020
* apply MKLDNNRun to quantized_act/transpose ops

* run CI
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants