Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[mxnet2.0] gluon 2.0 data: deprecate dataset transform= argument #17852

Merged
merged 2 commits into from
May 11, 2020

Conversation

zhreshold
Copy link
Member

Description

Fix #11141

This is part of changes for gluon 2.0 which addresses the usability issue.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

Copy link
Contributor

@leezu leezu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any timeline when to drop the deprecated argument?

@zhreshold
Copy link
Member Author

Is there any timeline when to drop the deprecated argument?

Ideally the first release after 2.0

@zhreshold
Copy link
Member Author

@mxnet-bot run ci [all]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [edge, centos-cpu, centos-gpu, unix-gpu, windows-gpu, unix-cpu, windows-cpu, clang, sanity, website, miscellaneous]

@leezu leezu merged commit 18b6e05 into apache:master May 11, 2020
AntiZpvoh pushed a commit to AntiZpvoh/incubator-mxnet that referenced this pull request Jul 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transforms are not compatible with DownloadedDatasets
4 participants