Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MKLDNN] Support quantized rnn towards v1.6.x #18028

Merged
merged 3 commits into from
Apr 13, 2020

Conversation

zixuanweeei
Copy link
Contributor

Description

Mirror PR of #18001, towards v1.6.x branch. In this PR, we add support of quantization flow of the rnn operator. Currently, only the LSTM mode supports INT8 inference.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Add _contrib_quantized_rnn op.
  • Add asymmetric quantization - _contrib_quantized_asym op, to quantize FP32 data to U8 data using scale and shift.
  • Add MXNET_USE_WEIGHT_CACHE to control rnn init behavior.
  • Support data layout in NDArrayIter. Specifically, NDArrayIter supports only NCHW layout by default, and there is no way to support other layouts, like sequential TNC layout. This PR makes some changes to NDArrayIter to leverage the feature (assuming that N represents the batch).
  • Move MKLDNNRnnMemMgr to individual layer.

##Comments##

@ciyongch @TaoLv @pengzhao-intel

* Add _contrib_quantized_rnn op

* Add asymmetric quantization - _contrib_quantized_asym op

* Add MXNET_USE_WEIGHT_CACHE to control rnn init behavior

* Support data layout in NDArrayIter

* Move MKLDNNRnnMemMgr to individual layer
@mxnet-bot
Copy link

Hey @zixuanweeei , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [unix-gpu, website, centos-gpu, edge, windows-gpu, sanity, centos-cpu, clang, miscellaneous, unix-cpu, windows-cpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@zixuanweeei
Copy link
Contributor Author

@mxnet-label-bot add [mkldnn]

@zixuanweeei
Copy link
Contributor Author

Accuracy and performance: #18001 (comment)

@zixuanweeei
Copy link
Contributor Author

CI checks passed. Please take a review. @ciyongch @TaoLv @pengzhao-intel

@ciyongch
Copy link
Contributor

LGTM for the current implementation, but we still need another DNNL patch (or DNNL version upgrade) to mitigate the overhead of _contrib_quantize_asym operator.

@zixuanweeei
Copy link
Contributor Author

LGTM for the current implementation, but we still need another DNNL patch (or DNNL version upgrade) to mitigate the overhead of _contrib_quantize_asym operator.

Sure, let's wait for the patch.

@pengzhao-intel
Copy link
Contributor

LGTM for the current implementation, but we still need another DNNL patch (or DNNL version upgrade) to mitigate the overhead of _contrib_quantize_asym operator.

Thanks, we can upgrade DNNL a little later and I will merge this PR for early testing.

Copy link
Contributor

@pengzhao-intel pengzhao-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants