Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix for out of bound access in QuantizedElemwiseMulOpShape (#18034) #18185

Merged
merged 1 commit into from
Apr 28, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/operator/quantization/quantized_elemwise_mul.cc
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ inline bool QuantizedElemwiseMulOpShape(const nnvm::NodeAttrs& attrs,
SHAPE_ASSIGN_CHECK(*in_attrs, quantized_elemwise_mul::kRhsMin, mxnet::TShape(1, 1));
SHAPE_ASSIGN_CHECK(*in_attrs, quantized_elemwise_mul::kRhsMax, mxnet::TShape(1, 1));

out_attrs->clear();
SHAPE_ASSIGN_CHECK(*out_attrs, quantized_elemwise_mul::kOut, lshape);
if (!params.enable_float_output) {
SHAPE_ASSIGN_CHECK(*out_attrs, quantized_elemwise_mul::kOutMin, mxnet::TShape(1, 1));
Expand Down
4 changes: 0 additions & 4 deletions tests/python/quantization/test_quantization.py
Original file line number Diff line number Diff line change
Expand Up @@ -353,10 +353,6 @@ def check_quantized_elemwise_mul(data_shape, qtype):
if is_test_for_native_cpu():
print('skipped testing quantized_elemwise_mul for native cpu since it is not supported yet')
return
if is_test_for_mkldnn():
print('skipped testing quantized_elemwise_mul for mkldnn due to '
'https://github.com/apache/incubator-mxnet/issues/18034')
return
elif qtype != 'int8':
print('skipped testing quantized_elemwise_mul for not supported data type')
return
Expand Down