-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
Hey @leezu , Thanks for submitting the PR
CI supported jobs: [miscellaneous, sanity, clang, website, windows-cpu, centos-gpu, centos-cpu, unix-cpu, unix-gpu, edge, windows-gpu] Note: |
Is this issue caused by using the g4 instances or do we have and clue of why they saw suddenly broken? |
I think this has been broken since it was introduced. Also, CI hasn't switched to G4 yet |
@mxnet-bot run ci [unix-gpu, windows-gpu, centos-gpu] |
Jenkins CI successfully triggered : [windows-gpu, centos-gpu, unix-gpu] |
So how did CI pass if it was broken? 🤔 |
Those features were not tested by CI. For some other tests that do rely on the broken feature, they are disabled, for example But the functionality in #18083 triggers the broken parts of TVMOP, and at this stage I think we should disable TVMOP on GPU feature instead of changing the way #18083 uses the mx.np API |
Thank you @jinboci for fixing the issue! Reverting this PR will indeed re-enable the previous test setup, but there may be some conflicts during the revert due to subsequent changes to the CI. You can try it though. Instead of reverting, my recommendation is to take a look at what tests this PR has removed and think about what the best strategy for testing the TVM_OP feature would be. For example, we can consider to test it only on the CentOS system tests or only on the Ubuntu system tests. But maybe this is not ideal. Do you have any recommendation about the best testing strategy? Sorry for the late response. |
@leezu Thank you very much for your suggestions. I don't have recommendations about testing strategy yet; however, I will take a look at the test code and see if there are better ways for testing. Thanks! |
Need to be fixed first before it can be tested on CI
#17886
#17840