Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

fix when clicking version dropdown it jumps to top of the page #18238

Merged
merged 1 commit into from
May 8, 2020
Merged

fix when clicking version dropdown it jumps to top of the page #18238

merged 1 commit into from
May 8, 2020

Conversation

ys2843
Copy link
Contributor

@ys2843 ys2843 commented May 4, 2020 •
edited
Loading

Description

This PR fixes #16231 , the fix is to delegate an event handler to parent node ul to prevent all its child nodes<a/> from triggering default click action (direct to target url, which cause the page to jump to the top).

To verify the change:
Go to get started page and see "Mxnet version" drop down, scroll down a little bit and hover on the version drop down. After selecting any of the version, the page should stay at where is was (compare to unexpectedly jump to top of the page).

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Tested on Chrome, Edge, Safari and Firefox
  • Tested on mobile

Changes

  • Fixed MXNet Version selection Drop-down makes page jump to top of page

Comments

@mxnet-bot
Copy link

Hey @ys2843 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [edge, centos-gpu, windows-gpu, centos-cpu, website, unix-cpu, miscellaneous, windows-cpu, sanity, clang, unix-gpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@ys2843
Copy link
Contributor Author

ys2843 commented May 4, 2020

@mxnet-label-bot add [website, pr-awaiting-review ]

@lanking520 lanking520 added pr-awaiting-review PR is waiting for code review Website labels May 4, 2020
@ys2843 ys2843 force-pushed the versionDropdownJumpToPageTop branch from c573080 to 723b36b Compare May 5, 2020 00:07
@ys2843
Copy link
Contributor Author

ys2843 commented May 5, 2020

@mxnet-bot run ci [centos-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [centos-cpu]

ChaiBapchya
ChaiBapchya suggested changes May 5, 2020
View reviewed changes
Copy link
Contributor

@ChaiBapchya ChaiBapchya left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It still jumps to top of the page

@ys2843
Copy link
Contributor Author

ys2843 commented May 5, 2020

Thanks @ChaiBapchya . It looks like the fix here only applies to the current master version of website. Because all pre master version websites are archived and any changes to pre master version need to made to static artifact repo maintained by @connorgoggins .
I will submit a PR to Connor's git repo and once finished I will update the preview. No changes required in this PR.

@ys2843 ys2843 mentioned this pull request May 5, 2020
Merged
@ChaiBapchya
Copy link
Contributor

Thanks for the clarification.

[ all pre master version websites are archived and any changes to pre master version need to made to static artifact repo maintained by @connorgoggins .
Has this been documented somewhere?

Like would any external MXNet contributor know about this "pre master version maintained somewhere else" point?

@connorgoggins
Copy link
Contributor

@ChaiBapchya the repository is being moved to a CodeCommit repo where access can be delegated to both internal and external contributors.

@ys2843
Copy link
Contributor Author

ys2843 commented May 6, 2020

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-gpu]

@ys2843
Copy link
Contributor Author

ys2843 commented May 6, 2020

@mxnet-bot run ci [ unix-gpu ]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-gpu]

@ys2843
Copy link
Contributor Author

ys2843 commented May 6, 2020

@mxnet-bot run ci [ unix-cpu ]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-cpu]

@ys2843 ys2843 force-pushed the versionDropdownJumpToPageTop branch from 723b36b to 06c41c7 Compare May 7, 2020 03:34
@ChaiBapchya
Copy link
Contributor

@ChaiBapchya the repository is being moved to a CodeCommit repo where access can be delegated to both internal and external contributors.

Has this been documented anywhere? @connorgoggins

@connorgoggins
Copy link
Contributor

@ChaiBapchya the website team has been informed of the move. Documentation will be added when the migration is complete.

@ChaiBapchya
Copy link
Contributor

Works good when the global version of website is 1.6.0
But when global version is master
And MXNet version selection dropdown in Get Started page is chosen then it misbehaves [goes to top of the page]

@ys2843
Copy link
Contributor Author

ys2843 commented May 7, 2020

@ChaiBapchya The change should apply to master now, could you try disable cache and reload the website? Thanks.

ChaiBapchya
ChaiBapchya approved these changes May 8, 2020
View reviewed changes
Copy link
Contributor

@ChaiBapchya ChaiBapchya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works smooth now!

apeforest
apeforest approved these changes May 8, 2020
View reviewed changes
Copy link
Contributor

@apeforest apeforest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apeforest apeforest merged commit 33dfbf7 into apache:master May 8, 2020
@ys2843 ys2843 deleted the versionDropdownJumpToPageTop branch May 8, 2020 22:18
AntiZpvoh pushed a commit to AntiZpvoh/incubator-mxnet that referenced this pull request Jul 6, 2020
@AntiZpvoh
fix when clicking version dropdown it jumps to top of the page (apach…
70dde10 
…e#18238)
ys2843 pushed a commit to ys2843/incubator-mxnet that referenced this pull request Sep 8, 2020
@ys2843
fix when clicking version dropdown it jumps to top of the page (apach…
172f44b 
…e#18238)
ys2843 pushed a commit to ys2843/incubator-mxnet that referenced this pull request Sep 19, 2020
@ys2843
fix when clicking version dropdown it jumps to top of the page (apach…
2e70277 
…e#18238)
ys2843 pushed a commit to ys2843/incubator-mxnet that referenced this pull request Sep 20, 2020
@ys2843
fix when clicking version dropdown it jumps to top of the page (apach…
b456a95 
…e#18238)
ys2843 added a commit that referenced this pull request Sep 21, 2020
@ys2843 @leezu
v1.x website patch (#19192)
a7b8606 
* Fixed Install page history broken (#18182)

* fix install option block history broke

* when history goes back, avoid button default css blue outline

* use appropriate parameter name

* format scss change

* Update website version select drop down (#18188)

* update version select drop down

* align caret

* revert scrollable content, add delayed hover effect

* bugfix

* fix new design doesn't work on mobile
# Conflicts:
#	docs/static_site/src/_includes/get_started/get_started.html

* Update website version select drop down (#18188)

* update version select drop down

* align caret

* revert scrollable content, add delayed hover effect

* bugfix

* fix new design doesn't work on mobile
# Conflicts:
#	docs/static_site/src/_includes/get_started/get_started.html

* Fix gluon link missing (#18243)

* fix gluon link missing

* empty commit to trigger checks

* empty commit to trigger checks

* fix when clicking version dropdown it jumps to top of the page (#18238)

* Website global search feature (#18288)

* init global search ui

* add hover effect to icon and refactor js

* add search bar ui styles

* fix search UI's effect on navbar height

* add fade in/out effect to search ui and navbar

* update search trigger to click and add x button for close

* add version select for search

* fix version typo

* update dropdown

* fix hitsperpage reset after change version

* fix nav trigger not show

* update search border css class name

* make dropdown style consistent

* global search mobile&tablet UI

* adjust mobile search result width

* extract global search related styles to a seperate scss

* restore formatting to existing code

* format & coding style

* fix caret height bug

* add mobile compatible UI

* add license header to js files and update dropdown width

* put docsearch css before main to overrides

* update search result panel height

* dynamically generate version dropdown

* use more accurate selector over search result

* use vh for height

* add comments  to scss

* move versions to Jekyll global variable

* remove redundant version key

* make global search default version the same as website version

Co-authored-by: Yang Shi <yangshia@amazon.com>

* replace google CDN with JQuery's own CDN (#18369)

Co-authored-by: Yang Shi <yangshia@amazon.com>

* Add Developer Guide Docs to MXNet Website (#18474)

* init dev guide

* move dev guide above FAQ

* update format and images

* hoist git docs and fix styles

* use relative urls

* remove useless code block

* use consistent url and file name

* update heading

* add apache license header

* init dev guide

* move dev guide above FAQ

* update format and images

* hoist git docs and fix styles

* use relative urls

* remove useless code block

* use consistent url and file name

* update heading

* add apache license header

* update doc - git clone recursive

* reviewing the dev guide - proof reading and text edits

Co-authored-by: Yang Shi <yangshia@amazon.com>
Co-authored-by: Talia Chopra <chopt@amazon.com>

* fix contribute page anchor position shifted (#18571)

Co-authored-by: Yang Shi <yangshia@amazon.com>

* Clipboard refactor (#18605)

* refactor clipboard

* make lang getter more extensible

* trigger ci

* User Feedback Widget (#18639)

* user feedback widget implementation

* add user feedback widget to python docs site

* update margin

* add apache license

* one more license

* turn off feedback widget on python site

* update copy

* format

* add event value field

* turn on widget on Python site
# Conflicts:
#	docs/static_site/src/_includes/head.html
#	docs/static_site/src/assets/main.scss

* Fix python micro-site table of content bugs (#18664)

* update footer style

* add compiled css of footer styles changes

* add same style for footer2

* more fix to the toc

* Fix all anchor shifts on website (#18674)

* use regex that is supported by all browsers (#18811)

* 1.7 compatible fix

* add jquery fix

* Consolidate installation instructions on website and add disclaimer for non-ASF ressources (#18487)

* Update website with disclaimer for non-ASF ressources

* Integrate Windows instructions to build_from_source.md

* Remove master version from selector

* Update Download links

* Update get_started/download.md per Release Download Page policy
# Conflicts:
#	contrib/clojure-package/README.md
#	docs/python_docs/python/tutorials/deploy/inference/image_classification_jetson.md
#	docs/static_site/src/_includes/get_started/get_started.html
#	docs/static_site/src/_includes/get_started/linux/clojure/gpu.md
#	docs/static_site/src/_includes/get_started/linux/java/gpu.md
#	docs/static_site/src/_includes/get_started/linux/julia/build-from-source.md
#	docs/static_site/src/_includes/get_started/linux/perl/perl.md
#	docs/static_site/src/_includes/get_started/linux/python/cpu/build-from-source.md
#	docs/static_site/src/_includes/get_started/linux/python/cpu/docker.md
#	docs/static_site/src/_includes/get_started/linux/python/cpu/pip.md
#	docs/static_site/src/_includes/get_started/linux/python/gpu/build-from-source.md
#	docs/static_site/src/_includes/get_started/linux/python/gpu/docker.md
#	docs/static_site/src/_includes/get_started/linux/python/gpu/pip.md
#	docs/static_site/src/_includes/get_started/linux/r/gpu.md
#	docs/static_site/src/_includes/get_started/linux/scala/cpu.md
#	docs/static_site/src/_includes/get_started/linux/scala/gpu.md
#	docs/static_site/src/_includes/get_started/macos
#	docs/static_site/src/_includes/get_started/macos/clojure/cpu.md
#	docs/static_site/src/_includes/get_started/macos/julia/build-from-source.md
#	docs/static_site/src/_includes/get_started/macos/perl/perl.md
#	docs/static_site/src/_includes/get_started/macos/python/cpu/build-from-source.md
#	docs/static_site/src/_includes/get_started/macos/python/cpu/docker.md
#	docs/static_site/src/_includes/get_started/macos/python/cpu/pip.md
#	docs/static_site/src/_includes/get_started/macos/python/gpu/build-from-source.md
#	docs/static_site/src/_includes/get_started/macos/python/gpu/pip_docker.md
#	docs/static_site/src/_includes/get_started/macos/r/cpu.md
#	docs/static_site/src/_includes/get_started/macos/scala/cpu.md
#	docs/static_site/src/_includes/get_started/windows
#	docs/static_site/src/_includes/get_started/windows/perl/perl.md
#	docs/static_site/src/_includes/get_started/windows/python/cpu/build-from-source.md
#	docs/static_site/src/_includes/get_started/windows/python/cpu/docker.md
#	docs/static_site/src/_includes/get_started/windows/python/cpu/pip.md
#	docs/static_site/src/_includes/get_started/windows/python/gpu/pip.md
#	docs/static_site/src/_includes/get_started/windows/r/cpu.md
#	docs/static_site/src/_includes/get_started/windows/r/gpu.md
#	docs/static_site/src/pages/get_started/build_from_source.md
#	docs/static_site/src/pages/get_started/download.md
#	docs/static_site/src/pages/get_started/osx_setup.md
#	docs/static_site/src/pages/get_started/ubuntu_setup.md
#	docs/static_site/src/pages/get_started/windows_setup.md

* fix broken installation widget - remove empty entries (#18661)

* update static files

# Conflicts:
#	docs/python_docs/themes/mx-theme/mxtheme/static/sphinx_materialdesign_theme.css
#	docs/python_docs/themes/mx-theme/mxtheme/static/sphinx_materialdesign_theme.css.map
#	docs/python_docs/themes/mx-theme/mxtheme/static/sphinx_materialdesign_theme.js
#	docs/python_docs/themes/mx-theme/mxtheme/static/sphinx_materialdesign_theme.js.map

* update header dropdown default version

* fix failed pipeline

* cherry pick 1.7 content from master

* update version number in image classification tutorial

* minor version fix

* fix bullet point format bug

* Fixed python website double scroller and improve UX (#18845)

* make python site header scroll aware and avoid double scroller

* add compiled assets

* adjust python site second header height

* add new line

* set focus to main content on DOM load
# Conflicts:
#	docs/python_docs/themes/mx-theme/mxtheme/static/sphinx_materialdesign_theme.css
#	docs/python_docs/themes/mx-theme/mxtheme/static/sphinx_materialdesign_theme.css.map
#	docs/python_docs/themes/mx-theme/mxtheme/static/sphinx_materialdesign_theme.js
#	docs/python_docs/themes/mx-theme/mxtheme/static/sphinx_materialdesign_theme.js.map
#	docs/python_docs/themes/mx-theme/src/scss/_root.scss

* add jekyll base url to enable relative path

* fix python micro site header link path

* update python site css

Co-authored-by: Yang Shi <ys2843@nyu.edu>
Co-authored-by: Talia Chopra <chopt@amazon.com>
Co-authored-by: Leonard Lausen <lausen@amazon.com>
ys2843 pushed a commit to ys2843/incubator-mxnet that referenced this pull request Sep 23, 2020
@ys2843
fix when clicking version dropdown it jumps to top of the page (apach…
ea7d8ff 
…e#18238)
samskalicky pushed a commit that referenced this pull request Sep 23, 2020
@ys2843 @szha
@ciyongch @leezu
[WEBSITE] v1.8 website patch (#19212)
975aa6e 
* Add missing license header for md files (#18541) (#19189)

Co-authored-by: ciyong <ciyong.chen@intel.com>

* Fixed Install page history broken (#18182)

* fix install option block history broke

* when history goes back, avoid button default css blue outline

* use appropriate parameter name

* format scss change

* Update website version select drop down (#18188)

* update version select drop down

* align caret

* revert scrollable content, add delayed hover effect

* bugfix

* fix new design doesn't work on mobile
# Conflicts:
#	docs/static_site/src/_includes/get_started/get_started.html

* Update website version select drop down (#18188)

* update version select drop down

* align caret

* revert scrollable content, add delayed hover effect

* bugfix

* fix new design doesn't work on mobile
# Conflicts:
#	docs/static_site/src/_includes/get_started/get_started.html

* Fix gluon link missing (#18243)

* fix gluon link missing

* empty commit to trigger checks

* empty commit to trigger checks

* fix when clicking version dropdown it jumps to top of the page (#18238)

* Website global search feature (#18288)

* init global search ui

* add hover effect to icon and refactor js

* add search bar ui styles

* fix search UI's effect on navbar height

* add fade in/out effect to search ui and navbar

* update search trigger to click and add x button for close

* add version select for search

* fix version typo

* update dropdown

* fix hitsperpage reset after change version

* fix nav trigger not show

* update search border css class name

* make dropdown style consistent

* global search mobile&tablet UI

* adjust mobile search result width

* extract global search related styles to a seperate scss

* restore formatting to existing code

* format & coding style

* fix caret height bug

* add mobile compatible UI

* add license header to js files and update dropdown width

* put docsearch css before main to overrides

* update search result panel height

* dynamically generate version dropdown

* use more accurate selector over search result

* use vh for height

* add comments  to scss

* move versions to Jekyll global variable

* remove redundant version key

* make global search default version the same as website version

Co-authored-by: Yang Shi <yangshia@amazon.com>

* replace google CDN with JQuery's own CDN (#18369)

Co-authored-by: Yang Shi <yangshia@amazon.com>

* Add Developer Guide Docs to MXNet Website (#18474)

* init dev guide

* move dev guide above FAQ

* update format and images

* hoist git docs and fix styles

* use relative urls

* remove useless code block

* use consistent url and file name

* update heading

* add apache license header

* init dev guide

* move dev guide above FAQ

* update format and images

* hoist git docs and fix styles

* use relative urls

* remove useless code block

* use consistent url and file name

* update heading

* add apache license header

* update doc - git clone recursive

* reviewing the dev guide - proof reading and text edits

Co-authored-by: Yang Shi <yangshia@amazon.com>
Co-authored-by: Talia Chopra <chopt@amazon.com>

* fix contribute page anchor position shifted (#18571)

Co-authored-by: Yang Shi <yangshia@amazon.com>

* Clipboard refactor (#18605)

* refactor clipboard

* make lang getter more extensible

* trigger ci

* User Feedback Widget (#18639)

* user feedback widget implementation

* add user feedback widget to python docs site

* update margin

* add apache license

* one more license

* turn off feedback widget on python site

* update copy

* format

* add event value field

* turn on widget on Python site
# Conflicts:
#	docs/static_site/src/_includes/head.html
#	docs/static_site/src/assets/main.scss

* Fix python micro-site table of content bugs (#18664)

* update footer style

* add compiled css of footer styles changes

* add same style for footer2

* more fix to the toc

* Fix all anchor shifts on website (#18674)

* use regex that is supported by all browsers (#18811)

* 1.7 compatible fix

* add jquery fix

* Consolidate installation instructions on website and add disclaimer for non-ASF ressources (#18487)

* Update website with disclaimer for non-ASF ressources

* Integrate Windows instructions to build_from_source.md

* Remove master version from selector

* Update Download links

* Update get_started/download.md per Release Download Page policy
# Conflicts:
#	contrib/clojure-package/README.md
#	docs/python_docs/python/tutorials/deploy/inference/image_classification_jetson.md
#	docs/static_site/src/_includes/get_started/get_started.html
#	docs/static_site/src/_includes/get_started/linux/clojure/gpu.md
#	docs/static_site/src/_includes/get_started/linux/java/gpu.md
#	docs/static_site/src/_includes/get_started/linux/julia/build-from-source.md
#	docs/static_site/src/_includes/get_started/linux/perl/perl.md
#	docs/static_site/src/_includes/get_started/linux/python/cpu/build-from-source.md
#	docs/static_site/src/_includes/get_started/linux/python/cpu/docker.md
#	docs/static_site/src/_includes/get_started/linux/python/cpu/pip.md
#	docs/static_site/src/_includes/get_started/linux/python/gpu/build-from-source.md
#	docs/static_site/src/_includes/get_started/linux/python/gpu/docker.md
#	docs/static_site/src/_includes/get_started/linux/python/gpu/pip.md
#	docs/static_site/src/_includes/get_started/linux/r/gpu.md
#	docs/static_site/src/_includes/get_started/linux/scala/cpu.md
#	docs/static_site/src/_includes/get_started/linux/scala/gpu.md
#	docs/static_site/src/_includes/get_started/macos
#	docs/static_site/src/_includes/get_started/macos/clojure/cpu.md
#	docs/static_site/src/_includes/get_started/macos/julia/build-from-source.md
#	docs/static_site/src/_includes/get_started/macos/perl/perl.md
#	docs/static_site/src/_includes/get_started/macos/python/cpu/build-from-source.md
#	docs/static_site/src/_includes/get_started/macos/python/cpu/docker.md
#	docs/static_site/src/_includes/get_started/macos/python/cpu/pip.md
#	docs/static_site/src/_includes/get_started/macos/python/gpu/build-from-source.md
#	docs/static_site/src/_includes/get_started/macos/python/gpu/pip_docker.md
#	docs/static_site/src/_includes/get_started/macos/r/cpu.md
#	docs/static_site/src/_includes/get_started/macos/scala/cpu.md
#	docs/static_site/src/_includes/get_started/windows
#	docs/static_site/src/_includes/get_started/windows/perl/perl.md
#	docs/static_site/src/_includes/get_started/windows/python/cpu/build-from-source.md
#	docs/static_site/src/_includes/get_started/windows/python/cpu/docker.md
#	docs/static_site/src/_includes/get_started/windows/python/cpu/pip.md
#	docs/static_site/src/_includes/get_started/windows/python/gpu/pip.md
#	docs/static_site/src/_includes/get_started/windows/r/cpu.md
#	docs/static_site/src/_includes/get_started/windows/r/gpu.md
#	docs/static_site/src/pages/get_started/build_from_source.md
#	docs/static_site/src/pages/get_started/download.md
#	docs/static_site/src/pages/get_started/osx_setup.md
#	docs/static_site/src/pages/get_started/ubuntu_setup.md
#	docs/static_site/src/pages/get_started/windows_setup.md

* fix broken installation widget - remove empty entries (#18661)

* update static files

# Conflicts:
#	docs/python_docs/themes/mx-theme/mxtheme/static/sphinx_materialdesign_theme.css
#	docs/python_docs/themes/mx-theme/mxtheme/static/sphinx_materialdesign_theme.css.map
#	docs/python_docs/themes/mx-theme/mxtheme/static/sphinx_materialdesign_theme.js
#	docs/python_docs/themes/mx-theme/mxtheme/static/sphinx_materialdesign_theme.js.map

* update header dropdown default version

* fix failed pipeline

* cherry pick 1.7 content from master

* update version number in image classification tutorial

* minor version fix

* fix bullet point format bug

* Fixed python website double scroller and improve UX (#18845)

* make python site header scroll aware and avoid double scroller

* add compiled assets

* adjust python site second header height

* add new line

* set focus to main content on DOM load
# Conflicts:
#	docs/python_docs/themes/mx-theme/mxtheme/static/sphinx_materialdesign_theme.css
#	docs/python_docs/themes/mx-theme/mxtheme/static/sphinx_materialdesign_theme.css.map
#	docs/python_docs/themes/mx-theme/mxtheme/static/sphinx_materialdesign_theme.js
#	docs/python_docs/themes/mx-theme/mxtheme/static/sphinx_materialdesign_theme.js.map
#	docs/python_docs/themes/mx-theme/src/scss/_root.scss

* add jekyll base url to enable relative path

* fix python micro site header link path

* update python site css

Co-authored-by: Sheng Zha <szha@users.noreply.github.com>
Co-authored-by: ciyong <ciyong.chen@intel.com>
Co-authored-by: Yang Shi <ys2843@nyu.edu>
Co-authored-by: Talia Chopra <chopt@amazon.com>
Co-authored-by: Leonard Lausen <lausen@amazon.com>
szha pushed a commit that referenced this pull request Sep 24, 2020
@ys2843 @leezu
[DOC] V1.7 website patch (#19102)
7efb5df 
* Fixed Install page history broken (#18182)

* fix install option block history broke

* when history goes back, avoid button default css blue outline

* use appropriate parameter name

* format scss change

* Update website version select drop down (#18188)

* update version select drop down

* align caret

* revert scrollable content, add delayed hover effect

* bugfix

* fix new design doesn't work on mobile
# Conflicts:
#	docs/static_site/src/_includes/get_started/get_started.html

* Update website version select drop down (#18188)

* update version select drop down

* align caret

* revert scrollable content, add delayed hover effect

* bugfix

* fix new design doesn't work on mobile
# Conflicts:
#	docs/static_site/src/_includes/get_started/get_started.html

* Fix gluon link missing (#18243)

* fix gluon link missing

* empty commit to trigger checks

* empty commit to trigger checks

* fix when clicking version dropdown it jumps to top of the page (#18238)

* Website global search feature (#18288)

* init global search ui

* add hover effect to icon and refactor js

* add search bar ui styles

* fix search UI's effect on navbar height

* add fade in/out effect to search ui and navbar

* update search trigger to click and add x button for close

* add version select for search

* fix version typo

* update dropdown

* fix hitsperpage reset after change version

* fix nav trigger not show

* update search border css class name

* make dropdown style consistent

* global search mobile&tablet UI

* adjust mobile search result width

* extract global search related styles to a seperate scss

* restore formatting to existing code

* format & coding style

* fix caret height bug

* add mobile compatible UI

* add license header to js files and update dropdown width

* put docsearch css before main to overrides

* update search result panel height

* dynamically generate version dropdown

* use more accurate selector over search result

* use vh for height

* add comments  to scss

* move versions to Jekyll global variable

* remove redundant version key

* make global search default version the same as website version

Co-authored-by: Yang Shi <yangshia@amazon.com>

* replace google CDN with JQuery's own CDN (#18369)

Co-authored-by: Yang Shi <yangshia@amazon.com>

* Add Developer Guide Docs to MXNet Website (#18474)

* init dev guide

* move dev guide above FAQ

* update format and images

* hoist git docs and fix styles

* use relative urls

* remove useless code block

* use consistent url and file name

* update heading

* add apache license header

* init dev guide

* move dev guide above FAQ

* update format and images

* hoist git docs and fix styles

* use relative urls

* remove useless code block

* use consistent url and file name

* update heading

* add apache license header

* update doc - git clone recursive

* reviewing the dev guide - proof reading and text edits

Co-authored-by: Yang Shi <yangshia@amazon.com>
Co-authored-by: Talia Chopra <chopt@amazon.com>

* fix contribute page anchor position shifted (#18571)

Co-authored-by: Yang Shi <yangshia@amazon.com>

* Clipboard refactor (#18605)

* refactor clipboard

* make lang getter more extensible

* trigger ci

* User Feedback Widget (#18639)

* user feedback widget implementation

* add user feedback widget to python docs site

* update margin

* add apache license

* one more license

* turn off feedback widget on python site

* update copy

* format

* add event value field

* turn on widget on Python site
# Conflicts:
#	docs/static_site/src/_includes/head.html
#	docs/static_site/src/assets/main.scss

* Fix python micro-site table of content bugs (#18664)

* update footer style

* add compiled css of footer styles changes

* add same style for footer2

* more fix to the toc

* Fix all anchor shifts on website (#18674)

* use regex that is supported by all browsers (#18811)

* 1.7 compatible fix

* add jquery fix

* Consolidate installation instructions on website and add disclaimer for non-ASF ressources (#18487)

* Update website with disclaimer for non-ASF ressources

* Integrate Windows instructions to build_from_source.md

* Remove master version from selector

* Update Download links

* Update get_started/download.md per Release Download Page policy
# Conflicts:
#	contrib/clojure-package/README.md
#	docs/python_docs/python/tutorials/deploy/inference/image_classification_jetson.md
#	docs/static_site/src/_includes/get_started/get_started.html
#	docs/static_site/src/_includes/get_started/linux/clojure/gpu.md
#	docs/static_site/src/_includes/get_started/linux/java/gpu.md
#	docs/static_site/src/_includes/get_started/linux/julia/build-from-source.md
#	docs/static_site/src/_includes/get_started/linux/perl/perl.md
#	docs/static_site/src/_includes/get_started/linux/python/cpu/build-from-source.md
#	docs/static_site/src/_includes/get_started/linux/python/cpu/docker.md
#	docs/static_site/src/_includes/get_started/linux/python/cpu/pip.md
#	docs/static_site/src/_includes/get_started/linux/python/gpu/build-from-source.md
#	docs/static_site/src/_includes/get_started/linux/python/gpu/docker.md
#	docs/static_site/src/_includes/get_started/linux/python/gpu/pip.md
#	docs/static_site/src/_includes/get_started/linux/r/gpu.md
#	docs/static_site/src/_includes/get_started/linux/scala/cpu.md
#	docs/static_site/src/_includes/get_started/linux/scala/gpu.md
#	docs/static_site/src/_includes/get_started/macos
#	docs/static_site/src/_includes/get_started/macos/clojure/cpu.md
#	docs/static_site/src/_includes/get_started/macos/julia/build-from-source.md
#	docs/static_site/src/_includes/get_started/macos/perl/perl.md
#	docs/static_site/src/_includes/get_started/macos/python/cpu/build-from-source.md
#	docs/static_site/src/_includes/get_started/macos/python/cpu/docker.md
#	docs/static_site/src/_includes/get_started/macos/python/cpu/pip.md
#	docs/static_site/src/_includes/get_started/macos/python/gpu/build-from-source.md
#	docs/static_site/src/_includes/get_started/macos/python/gpu/pip_docker.md
#	docs/static_site/src/_includes/get_started/macos/r/cpu.md
#	docs/static_site/src/_includes/get_started/macos/scala/cpu.md
#	docs/static_site/src/_includes/get_started/windows
#	docs/static_site/src/_includes/get_started/windows/perl/perl.md
#	docs/static_site/src/_includes/get_started/windows/python/cpu/build-from-source.md
#	docs/static_site/src/_includes/get_started/windows/python/cpu/docker.md
#	docs/static_site/src/_includes/get_started/windows/python/cpu/pip.md
#	docs/static_site/src/_includes/get_started/windows/python/gpu/pip.md
#	docs/static_site/src/_includes/get_started/windows/r/cpu.md
#	docs/static_site/src/_includes/get_started/windows/r/gpu.md
#	docs/static_site/src/pages/get_started/build_from_source.md
#	docs/static_site/src/pages/get_started/download.md
#	docs/static_site/src/pages/get_started/osx_setup.md
#	docs/static_site/src/pages/get_started/ubuntu_setup.md
#	docs/static_site/src/pages/get_started/windows_setup.md

* fix broken installation widget - remove empty entries (#18661)

* update static files

# Conflicts:
#	docs/python_docs/themes/mx-theme/mxtheme/static/sphinx_materialdesign_theme.css
#	docs/python_docs/themes/mx-theme/mxtheme/static/sphinx_materialdesign_theme.css.map
#	docs/python_docs/themes/mx-theme/mxtheme/static/sphinx_materialdesign_theme.js
#	docs/python_docs/themes/mx-theme/mxtheme/static/sphinx_materialdesign_theme.js.map

* update header dropdown default version

* fix failed pipeline

* cherry pick 1.7 content from master

* update version number in image classification tutorial

* minor version fix

* fix bullet point format bug

* Fixed python website double scroller and improve UX (#18845)

* make python site header scroll aware and avoid double scroller

* add compiled assets

* adjust python site second header height

* add new line

* set focus to main content on DOM load
# Conflicts:
#	docs/python_docs/themes/mx-theme/mxtheme/static/sphinx_materialdesign_theme.css
#	docs/python_docs/themes/mx-theme/mxtheme/static/sphinx_materialdesign_theme.css.map
#	docs/python_docs/themes/mx-theme/mxtheme/static/sphinx_materialdesign_theme.js
#	docs/python_docs/themes/mx-theme/mxtheme/static/sphinx_materialdesign_theme.js.map
#	docs/python_docs/themes/mx-theme/src/scss/_root.scss

* add jekyll base url to enable relative path

* fix python micro site header link path

* update python site css

Co-authored-by: Yang Shi <ys2843@nyu.edu>
Co-authored-by: Talia Chopra <chopt@amazon.com>
Co-authored-by: Leonard Lausen <lausen@amazon.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ChaiBapchya ChaiBapchya ChaiBapchya approved these changes

@apeforest apeforest apeforest approved these changes

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review Website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Website] MXNet Version selection Drop-down makes page jump to top of page
6 participants
@ys2843 @mxnet-bot @ChaiBapchya @connorgoggins @apeforest @lanking520