Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Numpy] New FFIs for Operator: squeeze, repeat, around, round, diagflat #18263

Merged
merged 6 commits into from
May 11, 2020
Merged

[Numpy] New FFIs for Operator: squeeze, repeat, around, round, diagflat #18263

merged 6 commits into from
May 11, 2020

Conversation

ryanwentaoxu
Copy link
Contributor

Description

(Brief description on what this PR is about)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@ryanwentaoxu ryanwentaoxu requested a review from szha as a code owner May 8, 2020 08:59
@mxnet-bot
Copy link

Hey @cassinixu , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-gpu, edge, unix-gpu, clang, miscellaneous, windows-cpu, centos-cpu, centos-gpu, unix-cpu, sanity, website]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@ryanwentaoxu
Copy link
Contributor Author

@hzfan

hzfan
hzfan approved these changes May 8, 2020
View reviewed changes
Copy link
Contributor

@hzfan hzfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/api/operator/numpy/np_matrix_op.cc Show resolved Hide resolved
@ryanwentaoxu
Copy link
Contributor Author

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu]

@ryanwentaoxu
Copy link
Contributor Author

@hzfan

@ryanwentaoxu
Copy link
Contributor Author

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu]

@ryanwentaoxu
Copy link
Contributor Author

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu]

@ryanwentaoxu
Copy link
Contributor Author

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu]

@ryanwentaoxu
Copy link
Contributor Author

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu]

@ryanwentaoxu
Copy link
Contributor Author

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu]

@yzhliu yzhliu merged commit 0523f09 into apache:master May 11, 2020
@yzhliu
Copy link
Member

yzhliu commented May 11, 2020

Thanks @cassinixu @hzfan

AntiZpvoh pushed a commit to AntiZpvoh/incubator-mxnet that referenced this pull request Jul 6, 2020
@ryanwentaoxu @AntiZpvoh
[Numpy] New FFIs for Operator: squeeze, repeat, around, round, diagfl…
7b0edf3 
…at (apache#18263)

* FFI new feature

* Feature ffi x 5

* Fix pylint error

* Fix pylint error

* Fix around error

* repeat modified
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yzhliu yzhliu yzhliu approved these changes

@hzfan hzfan hzfan approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ryanwentaoxu @mxnet-bot @yzhliu @hzfan