Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x]Enhance license checker to cover multiple license header and md files #18634

Merged
merged 2 commits into from
Jul 2, 2020

Conversation

ciyongch
Copy link
Contributor

Description

Backport #18478 and #18541 to enhance the current tools/icense_header.py, the main changes are listed as below:

  1. Enhance the current license checker to cover multiple license header and the *.md files.
  2. Add the statement in top level LICENSE for einsum and modulated_deformable_im2col related files.
  3. Add license for the md files which missed the header.

@szha @leezu @TaoLv @pengzhao-intel

@mxnet-bot
Copy link

Hey @ciyongch , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [edge, unix-cpu, windows-cpu, miscellaneous, clang, unix-gpu, website, centos-gpu, windows-gpu, sanity, centos-cpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@ciyongch
Copy link
Contributor Author

[centos-cpu] [centos-gpu][windows-gpu] jobs failed due to numpy 1.19.0 is used in CI, which is a known issue reported in #18600.

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link

Undefined action detected.
Permissible actions are : run ci [all], run ci [job1, job2]
Example : @mxnet-bot run ci [all]
Example : @mxnet-bot run ci [centos-cpu, clang]

@ciyongch
Copy link
Contributor Author

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-gpu]

@ciyongch
Copy link
Contributor Author

ciyongch commented Jul 1, 2020

Hi @szha , may I have your suggestion for the failed numpy UTs,

  1. add constraint to numpy version (<1.19.0) on 1.x CI
  2. disable the relative UTs
  3. wait for the fix on numpy version compatible PR to get this merged?

@szha
Copy link
Member

szha commented Jul 1, 2020

+1 for option 1 since the integration indeed needs fix. Thanks for driving this.

@ciyongch
Copy link
Contributor Author

ciyongch commented Jul 1, 2020

#18651 was created as described in option 1.

@ciyongch
Copy link
Contributor Author

ciyongch commented Jul 2, 2020

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-gpu]

@ciyongch
Copy link
Contributor Author

ciyongch commented Jul 2, 2020

Hi @leeze, @szha please help to review and merge.

@leezu leezu merged commit 366a7f8 into apache:v1.x Jul 2, 2020
@ciyongch ciyongch deleted the license_check_v1.x branch July 3, 2020 00:59
ChaiBapchya pushed a commit to ChaiBapchya/mxnet that referenced this pull request Aug 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants