Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[1.7] Revert "Fix memory leaks in Gluon" #18692

Merged
merged 1 commit into from
Jul 12, 2020
Merged

Conversation

rondogency
Copy link
Contributor

This reverts commit c4d9270 in 1.7 #18358

With the revert, we can train yolo with latest gluon cv without error

@rondogency rondogency requested a review from szha as a code owner July 10, 2020 22:42
@mxnet-bot
Copy link

Hey @rondogency , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-gpu, sanity, centos-gpu, unix-gpu, edge, unix-cpu, windows-cpu, website, clang, centos-cpu, miscellaneous]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@szha szha merged commit c4c7b11 into apache:v1.7.x Jul 12, 2020
@rondogency rondogency deleted the revert-weakref branch July 12, 2020 05:51
chinakook added a commit to chinakook/gluon-cv that referenced this pull request Nov 17, 2020
After this commit apache/mxnet#18328 , some memory leak were fixed.
Whitout this commit faster rcnn traning cannot be successfully closed.
These commits can be commit again after this yolo training fix.
apache/mxnet#18692
apache/mxnet@0496690
zhreshold added a commit to dmlc/gluon-cv that referenced this pull request Nov 24, 2020
* Fix yolo to support a memory leak fix

After this commit apache/mxnet#18328 , some memory leak were fixed.
Whitout this commit faster rcnn traning cannot be successfully closed.
These commits can be commit again after this yolo training fix.
apache/mxnet#18692
apache/mxnet@0496690

* fix all generator error in windows when training with multiprocessing

* add pylint disable not-callable

* Fix pylint

* Fix pylint

Co-authored-by: Joshua Z. Zhang <cheungchih@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants